Skip to content

Add nested type description section#4

Merged
wjwwood merged 5 commits intowjwwood:evolving_message_types_repfrom
methylDragon:ch3/nested_type_descriptions
Jul 23, 2022
Merged

Add nested type description section#4
wjwwood merged 5 commits intowjwwood:evolving_message_types_repfrom
methylDragon:ch3/nested_type_descriptions

Conversation

@methylDragon
Copy link
Copy Markdown
Collaborator

Ditto the title

@methylDragon
Copy link
Copy Markdown
Collaborator Author

Some things to consider (I added them in the REP also):

  • I think we should have strings for field_types to support custom type names (space-saving alternative on slack)
  • I think we should have type_name to store the name of the type (so we can use it to key the referenced_type_descriptions array)

@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch 3 times, most recently from 8afa1cb to aed663f Compare June 15, 2022 00:55
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from dfc421a to f6eb33b Compare July 8, 2022 00:49
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from 2425fe9 to 3039877 Compare July 8, 2022 19:49
@methylDragon
Copy link
Copy Markdown
Collaborator Author

See notes in introspection API section.

It's changed a lot to support nested types, and I'm unsure if I'm making good decisions...

@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from 63e06ae to 423f2f9 Compare July 15, 2022 03:16
Signed-off-by: methylDragon <methylDragon@gmail.com>
@methylDragon methylDragon force-pushed the ch3/nested_type_descriptions branch from 423f2f9 to 856372d Compare July 21, 2022 21:28
@wjwwood wjwwood merged commit 8dccc0f into wjwwood:evolving_message_types_rep Jul 23, 2022
@methylDragon methylDragon deleted the ch3/nested_type_descriptions branch September 8, 2022 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants