Methyl dragon/type description distribution#2
Merged
wjwwood merged 12 commits intoevolving_message_types_repfrom Jun 10, 2022
Merged
Methyl dragon/type description distribution#2wjwwood merged 12 commits intoevolving_message_types_repfrom
wjwwood merged 12 commits intoevolving_message_types_repfrom
Conversation
wjwwood
commented
Jun 1, 2022
Owner
Author
wjwwood
left a comment
There was a problem hiding this comment.
I have more of it to review, but here are my comments so far.
Base automatically changed from
methylDragon/fixups
to
evolving_message_types_rep
June 2, 2022 18:54
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: William Woodall <william+github@osrfoundation.org>
4bbc874 to
5095037
Compare
Collaborator
|
Rebased! |
wjwwood
commented
Jun 7, 2022
Owner
Author
wjwwood
left a comment
There was a problem hiding this comment.
Overall, really good, just a bunch of small changes and few places where maybe we need to discuss more.
Thanks!
Signed-off-by: methylDragon <methylDragon@gmail.com> Co-authored-by: William Woodall <william+github@osrfoundation.org> Co-authored-by: William Woodall <william+github@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@methylDragon your type description distribution changes as a pr. Builds on #1, so it should be merged first.