Skip to content

feat: Vulkan support #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giladgd merged 13 commits into from
Feb 24, 2024
Merged

feat: Vulkan support #171

giladgd merged 13 commits into from
Feb 24, 2024

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Feb 24, 2024 •
edited
Loading

Description of change

  • feat: Vulkan support
  • fix: free llama backend when garbage collected

Resolves #84

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd self-assigned this Feb 24, 2024
@giladgd giladgd marked this pull request as ready for review February 24, 2024 21:43
ido-pluto
ido-pluto approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@ido-pluto ido-pluto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giladgd giladgd merged commit d161bcd into beta Feb 24, 2024
@giladgd giladgd deleted the gilad/addVulkan branch February 24, 2024 21:52
@giladgd giladgd mentioned this pull request Feb 24, 2024
Merged
17 tasks
@github-actions
Copy link

github-actions bot commented Feb 24, 2024

🎉 This PR is included in version 3.0.0-beta.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@giladgd giladgd mentioned this pull request Mar 16, 2024
Merged
7 tasks
@giladgd giladgd mentioned this pull request Jul 28, 2024
Merged
7 tasks
@github-actions
Copy link

github-actions bot commented Sep 24, 2024 •
edited by giladgd
Loading

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto ido-pluto approved these changes

Assignees

@giladgd giladgd

Labels

released on @beta released

Projects

node-llama-cpp: roadmap
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@giladgd @ido-pluto