Skip to content

fix: optional typescript peer dependency #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
giladgd merged 1 commit into from
Dec 18, 2023
Merged

fix: optional typescript peer dependency #127

giladgd merged 1 commit into from
Dec 18, 2023

Conversation

@giladgd
Copy link
Member

@giladgd giladgd commented Dec 18, 2023 •
edited
Loading

Description of change

  • fix: add optional typescript peer dependency

Fixes #113

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@giladgd giladgd requested a review from ido-pluto December 18, 2023 20:02
@giladgd giladgd self-assigned this Dec 18, 2023
@giladgd giladgd changed the title fix: add optional typescript peer dependency fix: optional typescript peer dependency Dec 18, 2023
@giladgd giladgd merged commit ba975e9 into master Dec 18, 2023
@giladgd giladgd deleted the gilad/addTypescriptPeerDependency branch December 18, 2023 20:12
@github-actions
Copy link

github-actions bot commented Dec 18, 2023

🎉 This PR is included in version 2.8.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 21, 2024

🎉 This PR is included in version 3.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ido-pluto ido-pluto Awaiting requested review from ido-pluto

Assignees

@giladgd giladgd

Labels

released on @beta released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

node-llama-cpp doesn`t work with typescript

2 participants

@giladgd