Conversation
🦋 Changeset detectedLatest commit: cabe8d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for astro-starlight ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Could you explain why these fonts are “unnecessary”? |
|
The vendor-specific fonts (ie. The
Removing them simplifies the font stack with zero functional impact, as |
That seems reasonable enough. I checked Can I Use with Starlight’s browserslist query and it does looks like However, this PR also seems to change other stuff. The named fonts are different from the current ones. Is that intentional? |
|
Yes, that's intentional. I replaced some of the named fonts with the "Neo-Grotesque" and "Monospace Code" stacks from modernfontstacks for a cleaner cross-platform look. Also, I removed the Emoji fonts though I couldn't find out if |
|
I think it’s probably best to only remove the vendor-prefixed ones for now. That seems safe, but changing the rest of the font stack risks changing how people’s sites look which could be surprising or disruptive to them, so in the absence of a strong reason to do that, I think I’d rather stick with what we have. (We have to keep in mind that there are 10,000+ Starlight sites out there, so prefer to avoid arbitrary changes without having a clear idea of the impact.) |

Description
Remove redundant vendor-specific fonts (ie.
-apple-systemandBlinkMacSystemFont)