Skip to content

fix: Update fonts#3549

Merged
delucis merged 11 commits intomainfrom
unknown repository
Nov 28, 2025
Merged

fix: Update fonts#3549
delucis merged 11 commits intomainfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Nov 14, 2025

Description

Remove redundant vendor-specific fonts (ie. -apple-system and BlinkMacSystemFont)

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 14, 2025

🦋 Changeset detected

Latest commit: cabe8d9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link
Copy Markdown

netlify bot commented Nov 14, 2025

Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit cabe8d9
🔍 Latest deploy log https://app.netlify.com/projects/astro-starlight/deploys/6929d1dbdca1b00008070292
😎 Deploy Preview https://deploy-preview-3549--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100
Accessibility: 100
Best Practices: 100
SEO: 100
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@ghost ghost changed the title Update fonts patch 1 Update fonts Nov 14, 2025
@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label Nov 14, 2025
@ghost ghost changed the title Update fonts fix: Update fonts Nov 14, 2025
@delucis
Copy link
Copy Markdown
Member

delucis commented Nov 14, 2025

Could you explain why these fonts are “unnecessary”?

@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 14, 2025

The vendor-specific fonts (ie. -apple-system and BlinkMacSystemFont) were necessary before system-ui had broad browser support, but are now redundant.

The system-ui generic font family is now supported in all modern browsers and automatically loads the OS default font. Per MDN:

Glyphs are taken from the default user interface font on a given platform.

Removing them simplifies the font stack with zero functional impact, as system-ui handles all platforms uniformly.

@delucis
Copy link
Copy Markdown
Member

delucis commented Nov 14, 2025

The vendor-specific fonts (ie. -apple-system and BlinkMacSystemFont) were necessary before system-ui had broad browser support, but are now redundant.

That seems reasonable enough. I checked Can I Use with Starlight’s browserslist query and it does looks like system-ui covers our browser support range.

However, this PR also seems to change other stuff. The named fonts are different from the current ones. Is that intentional?

@ghost
Copy link
Copy Markdown
Author

ghost commented Nov 14, 2025

Yes, that's intentional. I replaced some of the named fonts with the "Neo-Grotesque" and "Monospace Code" stacks from modernfontstacks for a cleaner cross-platform look. Also, I removed the Emoji fonts though I couldn't find out if system-ui covers those as well so might add them back just in case.

@delucis
Copy link
Copy Markdown
Member

delucis commented Nov 17, 2025

I think it’s probably best to only remove the vendor-prefixed ones for now. That seems safe, but changing the rest of the font stack risks changing how people’s sites look which could be surprising or disruptive to them, so in the absence of a strong reason to do that, I think I’d rather stick with what we have. (We have to keep in mind that there are 10,000+ Starlight sites out there, so prefer to avoid arbitrary changes without having a clear idea of the impact.)

@delucis delucis added the 🌟 minor Change that triggers a minor release label Nov 24, 2025
@delucis delucis added this to the v0.37 milestone Nov 24, 2025
@delucis delucis added the ✅ approved Pull requests that have been approved and are ready to merge when next cutting a release label Nov 24, 2025
@delucis delucis merged commit 1cf50eb into withastro:main Nov 28, 2025
16 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✅ approved Pull requests that have been approved and are ready to merge when next cutting a release 🌟 core Changes to Starlight’s main package 🌟 minor Change that triggers a minor release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant