Skip to content

docs: add credits type to configuration reference#3034

Merged
delucis merged 1 commit intowithastro:mainfrom
HiDeoo:hd-docs-credits-type
Apr 5, 2025
Merged

docs: add credits type to configuration reference#3034
delucis merged 1 commit intowithastro:mainfrom
HiDeoo:hd-docs-credits-type

Conversation

@HiDeoo
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo commented Apr 4, 2025

Description

This PR adds the type and default value for the credits configuration option in the documentation. Noticed that it was missing while working on a different PR.

The type is fairly obvious, but this should still be documented nevertheless, just for consistency and completeness.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 4, 2025

⚠️ No Changeset found

Latest commit: 1951853

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 📚 docs Documentation website changes label Apr 4, 2025
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 4, 2025 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit 1951853
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/67f0182065b93700082730b5
😎 Deploy Preview https://deploy-preview-3034--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Apr 4, 2025

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/configuration.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

delucis
delucis approved these changes Apr 5, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting it! I blame releasing this feature live on stream for forgetting this 😁

@delucis delucis merged commit b8e487a into withastro:main Apr 5, 2025
16 checks passed
@jsparkdev jsparkdev mentioned this pull request Apr 6, 2025
Merged
@trueberryless trueberryless mentioned this pull request Apr 7, 2025
Merged
@HiDeoo HiDeoo mentioned this pull request Apr 7, 2025
Merged
@liruifengv liruifengv mentioned this pull request Apr 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HiDeoo @astrobot-houston @delucis