Skip to content

i18n(fr): Update guides/i18n.mdx from #2444 and #2524#2536

Merged
HiDeoo merged 5 commits intowithastro:mainfrom
thomasbnt:i18n-fr-update-guides-i18n-10292024
Oct 30, 2024
Merged

i18n(fr): Update guides/i18n.mdx from #2444 and #2524#2536
HiDeoo merged 5 commits intowithastro:mainfrom
thomasbnt:i18n-fr-update-guides-i18n-10292024

Conversation

@thomasbnt
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt commented Oct 29, 2024

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Oct 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d472f06

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Oct 29, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit d472f06
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/6722056969b654000898092a
😎 Deploy Preview https://deploy-preview-2536--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 29, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr guides/i18n.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@dreyfus92 dreyfus92 added the hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest label Oct 29, 2024
HiDeoo
HiDeoo requested changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a tiny comment regarding some wording but other than that, looks perfect to me 👍

@thomasbnt @HiDeoo
Update docs/src/content/docs/fr/guides/i18n.mdx
a18a937 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
@thomasbnt thomasbnt requested a review from HiDeoo October 30, 2024 09:50
HiDeoo
HiDeoo approved these changes Oct 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks perfect to me now, thanks for the update 🙌

@HiDeoo HiDeoo merged commit 67c95ef into withastro:main Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

@dreyfus92 dreyfus92 dreyfus92 approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes hacktoberfest-accepted Mark a PR as accepted to contribute towards Hacktoberfest i18n Anything to do with internationalization & translation efforts

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomasbnt @astrobot-houston @HiDeoo @dreyfus92