Skip to content

Add Biome config, lint script and lint CI job#1649

Closed
hippotastic wants to merge 11 commits intowithastro:mainfrom
hippotastic:add-biome
Closed

Add Biome config, lint script and lint CI job#1649
hippotastic wants to merge 11 commits intowithastro:mainfrom
hippotastic:add-biome

Conversation

@hippotastic
Copy link
Copy Markdown
Contributor

@hippotastic hippotastic commented Mar 20, 2024

Description

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 20, 2024 9:26pm
starlight-i18n 🔄 Building (Inspect) Visit Preview Mar 20, 2024 9:26pm

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 20, 2024

⚠️ No Changeset found

Latest commit: 09ef454

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Changes to GitHub Action workflows label Mar 20, 2024
@hippotastic hippotastic mentioned this pull request Mar 20, 2024
Merged
@hippotastic
Copy link
Copy Markdown
Contributor Author

hippotastic commented Mar 20, 2024 •
edited
Loading

Here are the differences I noticed vs ESLint:

Pros:

  • Simpler to configure
  • Much faster
  • The error messages generated by the CLI are awesome, include relevant code snippets and provide actionable recommendations

Cons:

  • There seems to be no equivalent for the no-floating-promises ESLint rule yet
  • The CLI output doesn't seem to be picked up by GitHub's problem matcher

@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Mar 21, 2024

Therel has a biome GitHub Action setup, I don't know if it works.
https://biomejs.dev/recipes/continuous-integration/

@hippotastic
Copy link
Copy Markdown
Contributor Author

hippotastic commented Mar 21, 2024

Closed for now after internal discussion, we'll start with ESLint and revisit a migration to Biome once the cons have been fixed in Biome. We love it though, really fast and promising!

@hippotastic hippotastic deleted the add-biome branch March 21, 2024 11:10
@awhitford awhitford mentioned this pull request Dec 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

🚨 action Changes to GitHub Action workflows

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hippotastic @liruifengv