Skip to content

Fix astro.config.mjs example syntax#1627

Merged
HiDeoo merged 2 commits intowithastro:mainfrom
alexcochran:patch-1
Mar 27, 2024
Merged

Fix astro.config.mjs example syntax#1627
HiDeoo merged 2 commits intowithastro:mainfrom
alexcochran:patch-1

Conversation

@alexcochran
Copy link
Copy Markdown
Contributor

@alexcochran alexcochran commented Mar 19, 2024

Description

This PR just fixes a small error in an astro.config.mjs example that I discovered as I was using these docs.

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 38bb039

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Mar 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview Mar 27, 2024 2:52pm

@github-actions github-actions bot added the 📚 docs Documentation website changes label Mar 19, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Mar 19, 2024

Hello! Thank you for opening your first PR to Starlight! ✨

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any issues you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🤩

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@at-the-vr
Copy link
Copy Markdown
Member

at-the-vr commented Mar 20, 2024

Solid suggestion Alex 😄 I wonder if you can cover this fix for remaining languages in starlight docs?

HiDeoo
HiDeoo approved these changes Mar 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting this and submitting a PR, super appreciated! 🙌

@HiDeoo HiDeoo merged commit 41c079f into withastro:main Mar 27, 2024
@jsparkdev jsparkdev mentioned this pull request Mar 28, 2024
Merged
@liruifengv liruifengv mentioned this pull request Mar 29, 2024
Merged
@morinokami morinokami mentioned this pull request Apr 7, 2024
Merged
@HiDeoo HiDeoo mentioned this pull request Aug 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees

No one assigned

Labels

📚 docs Documentation website changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alexcochran @astrobot-houston @at-the-vr @HiDeoo