Skip to content
This repository was archived by the owner on Nov 17, 2025. It is now read-only.

feat: upgrade to Volar 2.0 alpha#701

Merged
Princesseuh merged 27 commits intowithastro:mainfrom
johnsoncodehk:volar-1.12
Dec 15, 2023
Merged

feat: upgrade to Volar 2.0 alpha#701
Princesseuh merged 27 commits intowithastro:mainfrom
johnsoncodehk:volar-1.12

Conversation

@johnsoncodehk
Copy link
Copy Markdown
Contributor

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can be helpful as well.

Testing

Docs

@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Nov 16, 2023

⚠️ No Changeset found

Latest commit: dfcea99

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@johnsoncodehk johnsoncodehk mentioned this pull request Nov 16, 2023
42 tasks
@johnsoncodehk johnsoncodehk changed the title Prepare for Volar 1.12 Update to Volar 2.0 Nov 21, 2023
@johnsoncodehk johnsoncodehk changed the title Update to Volar 2.0 feat: upgrade to Volar 2.0 Dec 5, 2023
@johnsoncodehk johnsoncodehk changed the title feat: upgrade to Volar 2.0 feat: upgrade to Volar 2.0 alpha Dec 14, 2023
@johnsoncodehk johnsoncodehk marked this pull request as ready for review December 15, 2023 04:25
@Princesseuh Princesseuh merged commit 7de75d3 into withastro:main Dec 15, 2023
@johnsoncodehk johnsoncodehk deleted the volar-1.12 branch December 15, 2023 21:15
@spacedawwwg
Copy link
Copy Markdown

@johnsoncodehk @Princesseuh This update to Volar 2.0 alpha, astro check throws up loads of type issues that aren't being reported in the editor?

setting my overrides to "@astrojs/language-server": "2.5.3" has allowed us to get by for now - but my question is: Why would we suddenly start throwing up so many issues that weren't there before?

@Princesseuh
Copy link
Copy Markdown
Member

@johnsoncodehk @Princesseuh This update to Volar 2.0 alpha, astro check throws up loads of type issues that aren't being reported in the editor?

setting my overrides to "@astrojs/language-server": "2.5.3" has allowed us to get by for now - but my question is: Why would we suddenly start throwing up so many issues that weren't there before?

This PR hasn't been released. You're probably experiencing the following issue: #727

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants