Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
left a comment
There was a problem hiding this comment.
People are going to love this @natemoo-re , thanks for chipping in on the docs for this feature! Some quick comments below! 🎉
|
Should we also mention the default mode option in the config? |
|
@stramel - yes, we absolutely do need to mention that, too! I had reviewed this before that was in the other PR. When the docs/wording etc. there are confirmed, then we can come back and add here! 🙌 |
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
|
Made the updates that @sarah11918 suggested! Let me know if there's anything else I can do to help get this over the line! |
sarah11918
left a comment
There was a problem hiding this comment.
Thanks @natemoo-re and @stramel !
I also added the stuff for mode and now I will need your help because the section title title and intro paragraph are for "inlining svg" and ... now they're not always inlined! 😅
I think with my suggestions here this is good (correct whatever is necessary!) EXCEPT that we probably need to now be more general about this section. So, maybe this is "SVG components"? And the intro is more like, "Astro provides support for local .svg files as components..." Does that framing sound right?
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Hey @natemoo-re and @stramel ! As I think this feature is likely to be released tomorrow, I made some executive decisions and put this together (moved now to the bottom of the page for easy extraction as this content will soon live on its own page instead of in this guide). Would love at least a once-over that this content makes sense to you both, but no worries if this gets merged into beta docs with the feature before you've had a chance to review! They are just "beta" docs, and we can change 'em up real fast if and as we need to! |
|
PIVOT! I'm going to commit @natemoo-re 's changes and update branch so that we have the new Experimental Flag infrastructure! 🎏 Then, I'll move this into an experimental flag page, and you'll still have a chance to review before tomorrow's merge if necessary. Basically, instead of a heading, we'll need a page title and description, and possible sidebar label if we don't want the sidebar entry to match exactly the page title. |
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
|
Say hello to your new page!
|
|
Ooh, looks beautiful @sarah11918! Thanks for handling all the coordination, as always. Consider this an "author is happy if Team Docs is happy" situation! 💜 |
Description (required)
This PR adds a new section to the Images guide to introduce using
.svgimports as components.For Astro version:
5.x. See astro PR #12067.