Skip to content

Delete outdated markdown-content.mdx DE [i18nIgnore]#9778

Merged
yanthomasdev merged 5 commits intowithastro:mainfrom
flnzba:flnzba-markdown-content
Oct 30, 2024
Merged

Delete outdated markdown-content.mdx DE [i18nIgnore]#9778
yanthomasdev merged 5 commits intowithastro:mainfrom
flnzba:flnzba-markdown-content

Conversation

@flnzba
Copy link
Copy Markdown
Contributor

@flnzba flnzba commented Oct 23, 2024

added frontmatter.title

Description (required)

added frontmatter to post.title because could not recognize title from post without mentioning frontmatter

    {posts.map(post =>
  • {post.**frontmatter**.title}
  • )}

DE

Related issues & labels (optional)

  • Closes #
  • Suggested label:

YES

added frontmatter.title
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Oct 23, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Oct 23, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 44e5e57
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/672234a06fcc5e000856c948
😎 Deploy Preview https://deploy-preview-9778--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 23, 2024

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: i18nIgnore.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Note

The notes below indicate what would happen if the pull request is merged when triggering status changes. Since a ignored keyword was found in the PR's title, the status changes indicated below won't be applied.

Locale File Note
de basics/layouts.mdx Localization changed, will be marked as complete.
de guides/markdown-content.mdx Localization removed, will be marked as missing. 🔄️
de guides/migrate-to-astro.mdx Localization changed, will be marked as complete.
de guides/troubleshooting.mdx Localization changed, will be marked as complete.
de guides/upgrade-to/v3.mdx Localization changed, will be marked as complete.
de reference/api-reference.mdx Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@yanthomasdev
Copy link
Copy Markdown
Member

Thanks @flnzba, this page's translation is considerably outdated right now, so there's a lot that needs to be updated. We use Lunaria to track the status of each file using Git, so if we merge this PR, normally it would mark as if everything is updated, which is not the case.

Would you like to help us by updating the entire page? Here are all the updates missing that need to be reflected in the translation:
https://github.com/withastro/docs/commits/main/src/content/docs/en/guides/markdown-content.mdx?since=2023-08-31T14:47:15.000Z

@flnzba
Copy link
Copy Markdown
Contributor Author

flnzba commented Oct 23, 2024

Hi @yanthomasdev thank you for the information. I would be interested to contribute something useful to astro.
Do I understand correctly: All the changes from all the commits regarding the page markdown-content.mdx

(https://github.com/withastro/docs/commits/main/src/content/docs/en/guides/markdown-content.mdx?since=2023-08-31T14:47:15.000Z)

need to be put into one PR manually so all the changes can be merged?

(In other words the individual commits can not be merged because of Lunaria?)

Kind Regards

@yanthomasdev
Copy link
Copy Markdown
Member

We can merge the individual commits using i18nIgnore in the PR's title, if you just want to get this small change merged we can do that! It's just a preference for us to have the entire page updated instead of only a small part of it. Things tend to get a bit tricky maintenance-wise to review different parts of the same page on different PRs.

@flnzba
Copy link
Copy Markdown
Contributor Author

flnzba commented Oct 24, 2024

To get all open commits into one PR manually, it would take me a few hours. At the moment I don't have the time to do that. My recommendation would be to check all commits briefly and merge them if no bigger changes are made in the commits (most of them are changing one or two lines).
Then check the whole page and make new changes in a bigger commit/PR if necessary...
(Just my opinion...)

Maybe Github Workspace Copilot can do this?

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @flnzba ! As Yan mentioned, this page is very out of date, and in fact we were about to remove it entirely as part of our quality checking for outdated content. It is important that translated pages don't lag too far behind the original English content or we risk people relying on incorrect information.

In this case, I think the correct thing to do is go ahead and delete this page entirely from the German translation files. We were going to do that anyway, and so this is actually helpful to us! We can do that in this PR of yours, and then I will close the other PR that updates this same file.

Thank you for helping us with this, and if at some point you would like to contribute to the German translations, you are very welcome! For now, there is too much work to update this single page unless someone is willing to tackle it entirely. And this will be a helpful improvement so people aren't given wrong information.

@sarah11918 sarah11918 changed the title Update markdown-content.mdx DE Delete outdated markdown-content.mdx DE Oct 28, 2024
@sarah11918 sarah11918 added Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! and removed Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Oct 28, 2024
@yanthomasdev yanthomasdev changed the title Delete outdated markdown-content.mdx DE Delete outdated markdown-content.mdx DE [i18nIgnore] Oct 30, 2024
@yanthomasdev yanthomasdev merged commit 954cd90 into withastro:main Oct 30, 2024
@flnzba
Copy link
Copy Markdown
Contributor Author

flnzba commented Oct 30, 2024

Hi @flnzba ! As Yan mentioned, this page is very out of date, and in fact we were about to remove it entirely as part of our quality checking for outdated content. It is important that translated pages don't lag too far behind the original English content or we risk people relying on incorrect information.

In this case, I think the correct thing to do is go ahead and delete this page entirely from the German translation files. We were going to do that anyway, and so this is actually helpful to us! We can do that in this PR of yours, and then I will close the other PR that updates this same file.

Thank you for helping us with this, and if at some point you would like to contribute to the German translations, you are very welcome! For now, there is too much work to update this single page unless someone is willing to tackle it entirely. And this will be a helpful improvement so people aren't given wrong information.

@sarah11918 Hi Sarah,
thank you for your reply!

I will keep my eyes open for meaningful changes I can make to/for Astro and Astro docs.

Kind Regards
Florian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants