Skip to content

i18n(fr): fix inconsistent use of props/prop/property in French translation#9463

Merged
yanthomasdev merged 5 commits intowithastro:mainfrom
ArmandPhilippot:i18n/fr-fix-inconsistent-use-of-props
Sep 23, 2024
Merged

i18n(fr): fix inconsistent use of props/prop/property in French translation#9463
yanthomasdev merged 5 commits intowithastro:mainfrom
ArmandPhilippot:i18n/fr-fix-inconsistent-use-of-props

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot commented Sep 21, 2024

This PR follows up a discussion we had on Discord about consistency when translating props/prop here and in Starlight doc.

Description (required)

  • Use feminine form when we use props
  • Use props instead of propriétés when referring to components props
  • Replace prop (singular) with propriété (in Astro doc, it seems attribute is mostly used for native HTML attributes)

In addition, in the updated file I added some other small changes:

  • Replace quotation marks with guillemet
  • Fix some typo
  • Fix some erroneous translations
  • Reword some sentences that sounded weird
  • Translate in French some untranslated parts
  • Add/remove blank lines to make line numbers match English version (it's easier to find your way when there are updates)

Finally, in astro-components.mdx, I also added a missing change (see #6793).

Related issues & labels (optional)

  • Suggested label: i18n, consistency/formatting

@ArmandPhilippot
i18n(fr): update basics/astro-components.mdx
4162b8c 
* Use `props` with feminine form (`une propriété`)
* Replace singular `prop` with `property`
* Reword some sentences/Fix typo
* Use French quotes
* Add missing changes from withastro#6793 and withastro#5712
@ArmandPhilippot
i18n(fr): update guides/cms/apostrophecms.mdx
6773011 
* Make usage of `props`/`property` consistent
* Fix some typo
* Translate in French an untranslated part
@ArmandPhilippot
i18n(fr): make usage of props/prop consistent
9298197
@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Sep 21, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Sep 21, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit e6a175a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66f18cb01b987f00087db71c
😎 Deploy Preview https://deploy-preview-9463--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Sep 21, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr basics/astro-components.mdx Localization changed, will be marked as complete.
fr basics/astro-pages.mdx Localization changed, will be marked as complete.
fr basics/layouts.mdx Localization changed, will be marked as complete.
fr guides/client-side-scripts.mdx Localization changed, will be marked as complete.
fr guides/cms/apostrophecms.mdx Localization changed, will be marked as complete.
fr guides/cms/contentful.mdx Localization changed, will be marked as complete.
fr guides/cms/storyblok.mdx Localization changed, will be marked as complete.
fr guides/content-collections.mdx Localization changed, will be marked as complete.
fr guides/data-fetching.mdx Localization changed, will be marked as complete.
fr guides/framework-components.mdx Localization changed, will be marked as complete.
fr guides/integrations-guide/markdoc.mdx Localization changed, will be marked as complete.
fr guides/markdown-content.mdx Localization changed, will be marked as complete.
fr guides/migrate-to-astro/from-create-react-app.mdx Localization changed, will be marked as complete.
fr guides/migrate-to-astro/from-gatsby.mdx Localization changed, will be marked as complete.
fr guides/migrate-to-astro/from-nextjs.mdx Localization changed, will be marked as complete.
fr guides/migrate-to-astro/from-nuxtjs.mdx Localization changed, will be marked as complete.
fr guides/routing.mdx Localization changed, will be marked as complete.
fr guides/styling.mdx Localization changed, will be marked as complete.
fr guides/typescript.mdx Localization changed, will be marked as complete.
fr guides/view-transitions.mdx Localization changed, will be marked as complete.
fr recipes/build-custom-img-component.mdx Localization changed, will be marked as complete.
fr recipes/dynamically-importing-images.mdx Localization changed, will be marked as complete.
fr recipes/sharing-state-islands.mdx Localization changed, will be marked as complete.
fr reference/api-reference.mdx Localization changed, will be marked as complete.
fr reference/directives-reference.mdx Localization changed, will be marked as complete.
fr tutorial/4-layouts/2.mdx Localization changed, will be marked as complete.
fr tutorial/4-layouts/3.mdx Localization changed, will be marked as complete.
fr tutorial/5-astro-api/1.mdx Localization changed, will be marked as complete.
fr tutorial/5-astro-api/3.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ArmandPhilippot
ArmandPhilippot commented Sep 21, 2024
View reviewed changes
src/content/docs/fr/guides/typescript.mdx
<p><Since v="1.6.0" /></p>

Astro est livré avec des types utilitaires intégrés pour les types d'objets courants. Ils sont disponibles sous l'endpoint `astro/types`.
Astro est livré avec quelques types d'utilitaires intégrés pour les modèles courants de typage de propriété. Ceux-ci sont disponibles sous le point d'entrée `astro/types`.
Copy link
Copy Markdown
Member Author

@ArmandPhilippot ArmandPhilippot Sep 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not proud of this translation... but the previous version was a bit wrong if we compare it with the original version (using objets when it's properties). If you have a better suggestion, I'm all ears!

thomasbnt
thomasbnt approved these changes Sep 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

yanthomasdev
yanthomasdev approved these changes Sep 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Amazing work! 🙌

@yanthomasdev yanthomasdev merged commit 63aaff9 into withastro:main Sep 23, 2024
@ArmandPhilippot ArmandPhilippot deleted the i18n/fr-fix-inconsistent-use-of-props branch September 23, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasbnt thomasbnt thomasbnt approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArmandPhilippot @astrobot-houston @thomasbnt @yanthomasdev