Rename ViewTransitions to ClientRouter#9391
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Thanks @matthewp ! I will have to do a bunch of find and replace for regular text paragraphs and explanations, so there are a few decisions to make. Can you please also go through this section in the API reference and change any wording that you would no longer use when describing the API (including the name!). Knowing what you would now say on this page will help me with the questions I'll have (listed below): In general, we'll need to figure out things like:
|
|
I don't think anything really needs to change. The name of the thing being imported is all that has changed here. It still uses view transitions as a core part of the routing. It still attempts to mimic native routing as much as possible. Only the import has changed. We can quibble that some things are better worded different to differentiate the "real" view transitions MPA router vs ours, but those things could have / should have been worded differently before this change. The view transition guide itself could probably use a bit of refactoring to talk about the choice between the MPA routing and using ClientRouter (and breaking it up so that the ClientRouter parts are in their own sections), but I don't see why that needs to happen in this change. |
|
Perfect, thank you! |
|
Thanks @matthewp ! Will merge this in so I can start incorporating, check for any links that might have pointed to the changed header etc.! Note that the config reference docs need to be changed in the JS Doc in the Astro repo. If you get to it before I do, great. If not, I've made a note! |
|
Those are already done in my PR: withastro/astro#11980 |
|
Perfect, yup, I see it now! They were also committed here, so I'll just undo these changes locally. All good! |
Description (required)
Renames
ViewTransitionscomponent toClientRouterin all of the documentation.For Astro version:
5.x. See astro PR #11980.