Skip to content

i18n(fr): update api-reference.mdx and guides/view-transitions.mdx#9260

Merged
yanthomasdev merged 7 commits intowithastro:mainfrom
ArmandPhilippot:i18n/fr-update-api-reference.mdx
Aug 30, 2024
Merged

i18n(fr): update api-reference.mdx and guides/view-transitions.mdx#9260
yanthomasdev merged 7 commits intowithastro:mainfrom
ArmandPhilippot:i18n/fr-update-api-reference.mdx

Conversation

@ArmandPhilippot
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot commented Aug 29, 2024 •
edited
Loading

Description (required)

Related issues & labels (optional)

  • Suggested label: i18n

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 29, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 29, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 675b57e
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66d1f4058c96bf00077d68a7
😎 Deploy Preview https://deploy-preview-9260--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 29, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
fr guides/view-transitions.mdx Localization changed, will be marked as complete.
fr reference/api-reference.mdx Localization changed, will be marked as complete. 🔄️
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ArmandPhilippot ArmandPhilippot changed the title i18n(fr): update api-reference.mdx i18n(fr): update api-reference.mdx and guides/view-transitions.mdx Aug 29, 2024
@ArmandPhilippot ArmandPhilippot marked this pull request as ready for review August 29, 2024 22:48
@ArmandPhilippot ArmandPhilippot mentioned this pull request Aug 30, 2024
Merged
thomasbnt

This comment was marked as resolved.

Sign in to view

@ArmandPhilippot
Copy link
Copy Markdown
Member Author

ArmandPhilippot commented Aug 30, 2024

Thanks @thomasbnt! Some are not capitalized because they are not (and should not be) capitalized in the English documentation. In summary, if "view transitions" refers to the Astro API, it should be uppercase, but otherwise it should be lowercase. So I applied the same rule for transitions de vue.

I'll check that I haven't forgotten some capital letters where it applies, but for the rest, I'm not sure that the syntax needs to be updated.

@thomasbnt
Copy link
Copy Markdown
Member

thomasbnt commented Aug 30, 2024

Thanks @thomasbnt! Some are not capitalized because they are not (and should not be) capitalized in the English documentation. In summary, if "view transitions" refers to the Astro API, it should be uppercase, but otherwise it should be lowercase. So I applied the same rule for transitions de vue.

I'll check that I haven't forgotten some capital letters where it applies, but for the rest, I'm not sure that the syntax needs to be updated.

Okay! Then, LGTM!

thomasbnt
thomasbnt approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@thomasbnt thomasbnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ArmandPhilippot @thomasbnt
i18n(fr): fix View Transitions capitalization where legit
4e4fbd1 
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
@ArmandPhilippot
Copy link
Copy Markdown
Member Author

ArmandPhilippot commented Aug 30, 2024

Some of your suggestions was legit, this is fixed now. Thanks @thomasbnt!

yanthomasdev
yanthomasdev approved these changes Aug 30, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job peeps!

@yanthomasdev yanthomasdev merged commit 1d0e9c4 into withastro:main Aug 30, 2024
@ArmandPhilippot ArmandPhilippot deleted the i18n/fr-update-api-reference.mdx branch August 30, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasbnt thomasbnt thomasbnt approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ArmandPhilippot @astrobot-houston @thomasbnt @yanthomasdev