Skip to content

feat(i18n): document new i18n logic#9133

Merged
sarah11918 merged 8 commits into4.15.0from
feat/i18n-fallback
Aug 28, 2024
Merged

feat(i18n): document new i18n logic#9133
sarah11918 merged 8 commits into4.15.0from
feat/i18n-fallback

Conversation

@ematipico
Copy link
Copy Markdown
Member

@ematipico ematipico commented Aug 19, 2024 •
edited
Loading

Description (required)

This PR documents i18n.routing.fallbackType, a new feature that will change how the fallback works.

For Astro version: 4.15.0. See astro PR #11677

@ematipico ematipico added the minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. label Aug 19, 2024
@ematipico ematipico added this to the 4.15 milestone Aug 19, 2024
@netlify
Copy link
Copy Markdown

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 0cf6f2d
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66ccfc1e29b3b1000888390b
😎 Deploy Preview https://deploy-preview-9133--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 19, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/internationalization.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ematipico ematipico mentioned this pull request Aug 19, 2024
Merged
yanthomasdev
yanthomasdev reviewed Aug 19, 2024
View reviewed changes
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Aug 19, 2024
ematipico and others added 3 commits August 20, 2024 08:47
sarah11918
sarah11918 reviewed Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ematipico Take a look at what I've done and see what you think!

The existing Fallback content needed some revising anyway, because it described the existing behaviour of redirects everywhere.

Since this isn't a reference page, and we have full config reference items we can link to for fallback and fallbackType, this page can simply tell the story of what a fallback strategy looks like.

(Note, I will actually want to revisit the rest of this page in the same way at some point, but for now, let's just get the fallback in place!)

Let me know what you think of this, and whether seeing the big picture like this makes you want to e.g. move the option from i18n.routing and instead maybe rethink adding to fallback itself? When you look at what it takes to configure this, and how it is explained, you might think of a better way config could look to achieve a more complete fallback outcome. (setting in two places like this might seem a little clunky)

But, see what you think and let me know!

sarah11918
sarah11918 reviewed Aug 23, 2024
View reviewed changes
@sarah11918 sarah11918 mentioned this pull request Aug 23, 2024
Merged
@ematipico
Copy link
Copy Markdown
Member Author

ematipico commented Aug 26, 2024

Thank you @sarah11918 , I approve your new edits!

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Aug 26, 2024

Noting that the link check should pass once the new config reference docs have been pulled in!

sarah11918
sarah11918 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're in a good place here! 🥳

@sarah11918 sarah11918 changed the base branch from main to 4.15.0 August 26, 2024 22:06
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 26, 2024
yanthomasdev
yanthomasdev approved these changes Aug 27, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Aug 28, 2024

!coauthor

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 28, 2024 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>

@sarah11918 sarah11918 merged commit a99656e into 4.15.0 Aug 28, 2024
@sarah11918 sarah11918 deleted the feat/i18n-fallback branch August 28, 2024 21:01
@sarah11918 sarah11918 mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

4.15

Development

Successfully merging this pull request may close these issues.

4 participants

@ematipico @astrobot-houston @sarah11918 @yanthomasdev