Skip to content

Add timeout option to client:idle#9130

Merged
sarah11918 merged 6 commits intowithastro:4.15.0from
ph1p:add/client-idle-timeout
Aug 28, 2024
Merged

Add timeout option to client:idle#9130
sarah11918 merged 6 commits intowithastro:4.15.0from
ph1p:add/client-idle-timeout

Conversation

@ph1p
Copy link
Copy Markdown
Contributor

@ph1p ph1p commented Aug 19, 2024 •
edited
Loading

Description

Adds documentation for withastro/astro#11743

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 19, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 9cd5dd9
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66ccfbb25c0c170008970497
😎 Deploy Preview https://deploy-preview-9130--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ph1p ph1p mentioned this pull request Aug 19, 2024
Merged
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 19, 2024

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳.

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 19, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en reference/directives-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ph1p ph1p force-pushed the add/client-idle-timeout branch from e28332f to 76df2c3 Compare August 19, 2024 07:38
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Aug 19, 2024
@sarah11918 sarah11918 added this to the 4.15 milestone Aug 21, 2024
sarah11918
sarah11918 reviewed Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for these great docs @ph1p ! I've made some minor adjustments to the structure/style to fit with the rest of Astro docs, and have left a comment below!

@ph1p @sarah11918
Update src/content/docs/en/reference/directives-reference.mdx
e54c8f4 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
sarah11918 reviewed Aug 22, 2024
View reviewed changes
sarah11918
sarah11918 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with this one! Thank you again @ph1p , and welcome to Team Docs! 🥳

yanthomasdev
yanthomasdev approved these changes Aug 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good job @ph1p!

@sarah11918 sarah11918 changed the base branch from main to 4.15.0 August 26, 2024 22:03
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Aug 26, 2024
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Aug 28, 2024

!coauthor

@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 28, 2024 

Co-authored-by: Houston (Bot) <108291165+astrobot-houston@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>

@sarah11918 sarah11918 merged commit 11b1a9c into withastro:4.15.0 Aug 28, 2024
@sarah11918 sarah11918 mentioned this pull request Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

4.15

Development

Successfully merging this pull request may close these issues.

4 participants

@ph1p @astrobot-houston @sarah11918 @yanthomasdev