Skip to content

Overhaul @astrojs/sitemap docs#8997

Merged
delucis merged 2 commits intomainfrom
chris/sitemap-refresh
Aug 2, 2024
Merged

Overhaul @astrojs/sitemap docs#8997
delucis merged 2 commits intomainfrom
chris/sitemap-refresh

Conversation

@delucis
Copy link
Copy Markdown
Member

@delucis delucis commented Aug 2, 2024

This PR updates the docs for the @astrojs/sitemap integration.

My main aim was to be able to link directly to the information about linking to the sitemap in robots.txt for withastro/starlight#2083 (to avoid duplicating these docs in the Starlight docs).

But while there I realised this page is fairly dusty and could use a small refresh.

Reorganised, reworded, and re-prioritised things.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 2, 2024 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit dc481f3
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/66ace34b7a30ea0008fd611b
😎 Deploy Preview https://deploy-preview-8997--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Aug 2, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/sitemap.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@delucis delucis mentioned this pull request Aug 2, 2024
Merged
sarah11918
sarah11918 reviewed Aug 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks so much better @delucis ! Thank you! Left two small comments!

sarah11918
sarah11918 approved these changes Aug 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving! This is fantastic @delucis ! 🥳

at-the-vr
at-the-vr approved these changes Aug 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 never thought sitemap docs could be turned even simpler 😆

@delucis delucis added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Aug 2, 2024
@delucis delucis merged commit 0322891 into main Aug 2, 2024
@delucis delucis deleted the chris/sitemap-refresh branch August 2, 2024 13:56
@jsparkdev jsparkdev mentioned this pull request Aug 2, 2024
Merged
@Nin3lee Nin3lee mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

+1 more reviewer

@at-the-vr at-the-vr at-the-vr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@delucis @astrobot-houston @sarah11918 @at-the-vr