Skip to content

i18n(de): add solid integration guide#8624

Merged
yanthomasdev merged 6 commits intowithastro:mainfrom
DerTimonius:i18n/de-add-solid-guide
Jul 15, 2024
Merged

i18n(de): add solid integration guide#8624
yanthomasdev merged 6 commits intowithastro:mainfrom
DerTimonius:i18n/de-add-solid-guide

Conversation

@DerTimonius
Copy link
Copy Markdown
Contributor

Description (required)

supersedes #8148

This PR adds the missing german translation for the SolidJS integration guide

I checked the original docs again and added what was missing

@vercel

This comment was marked as outdated.

@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 21, 2024
@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jun 21, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
de guides/integrations-guide/solid-js.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Copy Markdown
Contributor

@Maxframe Maxframe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saubere Arbeit!
Kenne mich persönlich nicht mit SolidJS aus, habe aber sonst so keine wirklichen Fehler finden können 👍

Gibt es sonst Dinge, bei denen du dir hier nicht sicher bist?

Comment thread src/content/docs/de/guides/integrations-guide/solid-js.mdx Outdated
Co-authored-by: Max <51922004+Maxframe@users.noreply.github.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Jul 13, 2024

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 761b9fd
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/669570592fe97000085a117c
😎 Deploy Preview https://deploy-preview-8624--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DerTimonius
Copy link
Copy Markdown
Contributor Author

oh, did not see that this is still open...
@Maxframe I don't have any more questions here, so this should be good to go

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@yanthomasdev yanthomasdev merged commit d6177a1 into withastro:main Jul 15, 2024
@DerTimonius DerTimonius deleted the i18n/de-add-solid-guide branch July 15, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants