Sidebar Reorganization Implementation#8197
Conversation
Removed Contribute Section from RightSideBar and Added Translate Page beside Edit Page.
- Added dedicated footer component to override default footer generated by Starlight. - Added Pagination, EditLink and References component to file. Added LastUpdated (commented) for possible future development. - Removed Contribute section completely from TableOfContents. - Updated FeedbackButton and Feedback Form to have accurate styling. - Added Footer to astro.config.ts.
This comment was marked as outdated.
This comment was marked as outdated.
dreyfus92
left a comment
There was a problem hiding this comment.
Hey @SatanshuMishra, awesome job thanks for tackling this. I believe we can remove this unused import.
delucis
left a comment
There was a problem hiding this comment.
Thank you for putting this together @SatanshuMishra! Really appreciate you picking it up. I’ve left some initial feedback.
There are probably also two details to discuss:
-
Are we happy with this also being added to the homepage? (My gut instinct is yes, it’s nice.)
-
Whether we want any extra space between the pagination links and the new footer links. Curious what others think on this one.
| font-size: var(--sl-text-2xl); | ||
| cursor: pointer; | ||
| text-decoration: none; | ||
| color: white; |
There was a problem hiding this comment.
Same here for the colours — white text is not visible in light mode.
| text-decoration: none; | ||
| background-color: var(--sl-color-gray-5); | ||
| } | ||
|
|
||
| .select-buttons h2 { | ||
| font-size: var(--sl-text-h5); | ||
| font-weight: 600; | ||
| line-height: var(--sl-line-height-headings); | ||
| margin-bottom: 0.5rem; | ||
| text-decoration: none; |
There was a problem hiding this comment.
I’m not quite clear what the changes inside the feedback modal are doing? Comparing the preview and the live site, the live site’s styles seem correct, so I think we should aim to match them (which is maybe as simple as not changing anything?)
There was a problem hiding this comment.
I discovered that moving the FeedbackButton outside the RightSideBar made some scoped CSS in-accessible. This made the formatting for the title in correct. The above fixes this. It is the same style as before (take directly from inspect). I'm not sure if there is some other way to keep the formatting.
Remove un-used component mention. Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
Remove un-used component import. Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
I think this looks good too @delucis! Certainly nice to give people to learn about how to contribute, give us feedback or see the amazing community page we have. |
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
- Changed References to FooterLinks - Changed color consistency for Footer and FeedbackButton.
TheOtterlord
left a comment
There was a problem hiding this comment.
Here's the translation snippets for the untranslated strings
|
Overall, it would look better if both the link lists were always aligned to the center, perhaps even with a top border to separate the footer from the rest of the content. |
There was a problem hiding this comment.
At getting-started the bottom padding of the Discord button looks a little weird.
Details
Details
Hey @TheOtterlord! I'm not sure if translation suggestions should be submitted on this PR. They may need to be their own PRs since this PR focuses on generating the new structure. Feel free to correct me if I'm wrong through! |
|
The suggestions apply our existing translations from the old structure, so we're not introducing any new translations. |
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
sarah11918
left a comment
There was a problem hiding this comment.
This looks great! I tested at a few different screen sizes, and love having everything always visible in the new footer.
delucis
left a comment
There was a problem hiding this comment.
Thanks for your patience on this one @SatanshuMishra! I spent a bit of time tidying up loose ends and should now be good to go. Thank you for contributing this! 🚀
Description (required)
This PR aims to implement the changes proposed in #6845. The changes made include:
Translateoption was moved beside theEdit Pageoption at the bottom of the page above the Pagination.Referencescomponent was created to hold the links to theContribute,Give Feedback, andCommunitypages.Footercomponent created to override the default Starlight Footer. ThePagination,EditLinks, &Referencescomponents were added to this component (as before). TheLastUpdatedcomponent was also added (commented out) for possible future development.Give FeedbackandCommunityoptions.Related issues & labels (optional)
site-improvementPreview of changed:
Current Implementation:
Proposed Changes:
Special thanks to @delucis for coming up with the design and guidance throughout this implementation.