Update default image service section#6073
Merged
sarah11918 merged 2 commits into4.1.0from Jan 4, 2024
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
yanthomasdev
approved these changes
Jan 3, 2024
Member
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM! I'll let Sarah make the call of when to merge.
sarah11918
approved these changes
Jan 3, 2024
Member
sarah11918
left a comment
There was a problem hiding this comment.
Looks great! Since the specific Sharp config option isn't actually live until the minor release, I'll save this to merge with the other release docs. But, we should have had a link to config reference regardless, so this is perfect!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
From withastro/astro#9546 (comment), Sarah suggested that the "Default image service" section could have a link to the
image.serviceoption explaning how to configure options for an image service.Related issues & labels (optional)
For Astro version:
4.1. See astro PR withastro/astro#9546Don't think there's a big harm if we merge this without waiting for withastro/astro#9546? I guess I'll let y'all decide so the PR is properly labelled 😅