Skip to content

Document Astro.cookie options#6042

Merged
sarah11918 merged 4 commits into4.1.0from
new-cookie-options
Jan 4, 2024
Merged

Document Astro.cookie options#6042
sarah11918 merged 4 commits into4.1.0from
new-cookie-options

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

@matthewp matthewp commented Jan 2, 2024

Description (required)

  • Documents the previously undocumented SetCookieOptions to customize cookie setting.
  • Adds new encode and decode options.

Related issues & labels (optional)

For Astro version: 4.x. See astro PR #9063.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 4, 2024 3:26am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 3:26am

@matthewp matthewp mentioned this pull request Jan 2, 2024
Merged
@sarah11918 sarah11918 added this to the 4.1.0 milestone Jan 2, 2024
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Jan 2, 2024
sarah11918
sarah11918 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

yanthomasdev
yanthomasdev reviewed Jan 3, 2024
View reviewed changes
yanthomasdev
yanthomasdev approved these changes Jan 3, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sarah11918 sarah11918 changed the base branch from main to 4.1.0 January 3, 2024 17:32
@sarah11918 sarah11918 merged commit 59cc602 into 4.1.0 Jan 4, 2024
@sarah11918 sarah11918 deleted the new-cookie-options branch January 4, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

4.1.0

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewp @sarah11918 @yanthomasdev