Update directives-reference.mdx with optional root margin#6038
Update directives-reference.mdx with optional root margin#6038sarah11918 merged 5 commits intowithastro:4.1.0from
Conversation
Documentation for optional root margin on client visible. This documents this pr withastro/astro#9363
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
|
Hello! Thank you for opening your first PR to Astro’s Docs! 🎉 Here’s what will happen next:
|
sarah11918
left a comment
There was a problem hiding this comment.
Thank you for this great contribution, @3ddyBoi ! I've just tightened up some of the wording to make it more consistent with the other sections. I also added our special component for indicating when a feature was added. (We don't write "new" in the docs because... when is it no longer new? Will we remember to go back and remove it when it's no longer "new"?) It's more helpful for readers to know exactly which version this was introduced so they know whether it's available in their version of Astro!
This will be ready for tomorrow's 4.1 minor release, and we are pleased to welcome you to Team Docs! 🥳
yanthomasdev
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the great work 🚀
|
Updated the PR to reflect the new syntax introduced in this PR in core: withastro/astro#9596 |
Documentation for optional root margin on client visible. This documents this pr withastro/astro#9363
Description (required)
This documents the PR withastro/astro#9363 for astro. It shouldn't be merged before the PR is merged. The change is for having root margin as a possiblity.
Related issues & labels (optional)