feat(overlay): Add new components and adjust current ones#5516
Closed
Princesseuh wants to merge 3 commits intomainfrom
Closed
feat(overlay): Add new components and adjust current ones#5516Princesseuh wants to merge 3 commits intomainfrom
Princesseuh wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sarah11918
reviewed
Nov 29, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Amazing work, @Princesseuh ! I made some suggestions below for you to consider!
Member
|
Hi @Princesseuh Just wanted to check whether you were OK with these changes! I know you have limited internet right now, so I'm going to go ahead and commit these so you don't have to do it. Then you can comment with any changes needed! 🙌 |
Member
|
Comparing this to Matthew's newer PR that (re)names everything! |
sarah11918
requested changes
Dec 2, 2023
Member
|
Closing as these changes were brought in and merged with #5541 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Docs for withastro/astro#9118
New components were added and some of the current ones were slightly reworked to be more generic.