Skip to content

feat: improve typescript global types guide#5051

Merged
sarah11918 merged 2 commits intowithastro:mainfrom
florian-lefebvre:feat/typescript-global-types
Oct 12, 2023
Merged

feat: improve typescript global types guide#5051
sarah11918 merged 2 commits intowithastro:mainfrom
florian-lefebvre:feat/typescript-global-types

Conversation

@florian-lefebvre
Copy link
Copy Markdown
Member

Description (required)

This improves the TS guide on global types declaration. For context:
image

Related issues & labels (optional)

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 12, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 56d8162
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6527f5c7352a31000882c143
😎 Deploy Preview https://deploy-preview-5051--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Copy Markdown
Contributor

@astrobot-houston astrobot-houston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Oct 12, 2023
Co-authored-by: Erika <3019731+Princesseuh@users.noreply.github.com>
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Go Team... Team Docs, which is now your team, @florian-lefebvre ! 🥳

@sarah11918 sarah11918 merged commit efd5e73 into withastro:main Oct 12, 2023
@florian-lefebvre florian-lefebvre deleted the feat/typescript-global-types branch October 12, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants