Updating outdated information for astro check documentation for Astro 3 #4899
Merged
sarah11918 merged 2 commits intowithastro:mainfrom Oct 2, 2023
jdwilkin4:docs-4789-update-astro-check-docs
Merged
Updating outdated information for astro check documentation for Astro 3 #4899sarah11918 merged 2 commits intowithastro:mainfrom jdwilkin4:docs-4789-update-astro-check-docs
sarah11918 merged 2 commits intowithastro:mainfrom
jdwilkin4:docs-4789-update-astro-check-docs
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
sarah11918
approved these changes
Oct 2, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Thanks so much for snagging this error and making the fix, @jdwilkin4 ! This looks great, and is so helpful. 🙌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
This PR removes the mention of
tsc --noEmitin both thepackage.jsonexample and note for astro check docs in the Type Checking section for astro 3.Link to page with the fix
Before
After
Related Issue / Implementation PR
astro checkdocumentation is outdated for Astro 3 #4789