[en-only] Fix broken URL reference in testing docs#4722
Merged
sarah11918 merged 2 commits intowithastro:mainfrom Sep 16, 2023
yeskunall:fix-broken-url-ref-testing-mdx
Merged
[en-only] Fix broken URL reference in testing docs#4722sarah11918 merged 2 commits intowithastro:mainfrom yeskunall:fix-broken-url-ref-testing-mdx
sarah11918 merged 2 commits intowithastro:mainfrom
yeskunall:fix-broken-url-ref-testing-mdx
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
dreyfus92
approved these changes
Sep 15, 2023
Member
dreyfus92
left a comment
There was a problem hiding this comment.
Nice catch @yeskunall, once this change is merged, we have a i18n tracker which will mark this as a change required in other locales so other translators can handle it. Thank you for this 😁
sarah11918
approved these changes
Sep 16, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Looks great! Thank you so much for the updated link @yeskunall , and thank you for thinking of the translators! As was already mentioned, it's better for our system if each language updates it themselves, so this will start the ball rolling with the English, and we'll take it from there! 🙌 Welcome to Team Docs!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
What does this PR change? Give us a brief description.
The older link reference returns a 404 if JavaScript is disabled (as was in my case), or redirects you to a resource which still does not directly mention how to use a development server with Playwright. I found an updated—and IMO, better—resource for the same.
Did you change something visual? A before/after screenshot can be helpful.
N/A
PS: Since this is simply a change in the URL ref, LMK if it’s OK for me to update it in the other languages too, in which case I’ll also update the PR title. I didn’t want to cause any unnecessary trouble for the translators.
💖