Skip to content

i18n(zh-CN): Update translations in v3.mdx, images.mdx and typescript.mdx#4455

Merged
yanthomasdev merged 6 commits intowithastro:mainfrom
Genteure:translate/pr-4446
Sep 1, 2023
Merged

i18n(zh-CN): Update translations in v3.mdx, images.mdx and typescript.mdx#4455
yanthomasdev merged 6 commits intowithastro:mainfrom
Genteure:translate/pr-4446

Conversation

@Genteure
Copy link
Copy Markdown
Contributor

@Genteure Genteure commented Aug 30, 2023 •
edited
Loading

What kind of changes does this PR include?

  • Translated content

Description

Translate content added in #4446, #4447, #4495 and #4498.

@netlify
Copy link
Copy Markdown

netlify bot commented Aug 30, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 1a7ada8
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/64f217b8dcbecf000887375f
😎 Deploy Preview https://deploy-preview-4455--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Aug 30, 2023
Genteure
Genteure commented Aug 30, 2023
View reviewed changes
src/content/docs/zh-cn/guides/upgrade-to/v3.mdx
- 废弃的脚本/样式类型：请参阅 [0.26 迁移指南](/zh-cn/guides/upgrade-to/v1/#new-default-script-behavior)

### 移除： 内容集合 schema 中来自 `astro:content` 的 `image`
### 移除：服务器代码中 Web API 的不完整垫片（shim）
Copy link
Copy Markdown
Contributor Author

@Genteure Genteure Aug 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this translation for "shims".

This is a literal translation based on the Wikipedia article "垫片 (程序设计)".

"Polyfill" is well understood and usually left untranslated, maybe "shim" should also be left as is.

Copy link
Copy Markdown
Member

@liruifengv liruifengv Aug 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's hard to translate.

We can do that for now.

@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Aug 31, 2023 •
edited
Loading

建议同个文件合并到一个PR进行提交，一旦 PR被合并之后，该页面的翻译状态就会被标记成完成。

我们应该以文件为单位更新，而不是以原文的pr为单位，同一个文件提交一个PR，包含所有更改内容。如果页面之间有引用关系导致了broken link，可以包含在同一个PR内。

可以看一下翻译状态页面：https://i18n.docs.astro.build/

@Genteure Genteure changed the title i18n(zh_CN): Translate content added in #4446 i18n(zh-CN): Translate content added in #4446 and #4447 Aug 31, 2023
@Genteure Genteure mentioned this pull request Aug 31, 2023
Closed
liruifengv
liruifengv approved these changes Aug 31, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@liruifengv liruifengv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Aug 31, 2023

@Genteure 我在英文原文有一个新提交：#4464

@Genteure
Copy link
Copy Markdown
Contributor Author

Genteure commented Aug 31, 2023

I have updated this PR accordingly.

@100gle
Copy link
Copy Markdown
Contributor

100gle commented Sep 1, 2023 •
edited
Loading

Note that there are something updates for v3.mdx in #4495, #4498

@Genteure Genteure changed the title i18n(zh-CN): Translate content added in #4446 and #4447 i18n(zh-CN): Update translations in v3.mdx, images.mdx and typescript.mdx Sep 1, 2023
@Genteure
Copy link
Copy Markdown
Contributor Author

Genteure commented Sep 1, 2023

I have rebased the changes onto current main and added changes made in those two PRs.

@Genteure Genteure requested a review from liruifengv September 1, 2023 15:45
100gle
100gle approved these changes Sep 1, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@100gle 100gle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

yanthomasdev
yanthomasdev approved these changes Sep 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks peeps 🚀

@yanthomasdev yanthomasdev merged commit 45566c4 into withastro:main Sep 1, 2023
@Genteure Genteure deleted the translate/pr-4446 branch September 1, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@liruifengv liruifengv Awaiting requested review from liruifengv

+1 more reviewer

@100gle 100gle 100gle approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Genteure @liruifengv @100gle @yanthomasdev