Polished component and especially slot content#397
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@Jutanium Here are the fruits of our orangey labours! (Where are our socks, indeed?) |
|
🧦 🧦 ❤️ |
aFuzzyBear
left a comment
There was a problem hiding this comment.
Just a few thoughts, Ill be back , need to rest eyes,
|
Quick note, since I'm not yet sitting down to really tackle this, just to give some context to steer the convo by the time I get there: 😄 Based on feedback/issues re: using slots with other framework components that also have a concept of slots, @Jutanium and I tried to reorganize the logical flow of material to see if that would help preempt that particular problem. Essentially: FROM: slots are placeholders, components with slots are wrappers TO: some components can have "children" html elements that get passed to them; that stuff goes in to a component's slot. (and, eg, that's why showing the file using the component first, THEN the component with the slot in the code examples.) So, that's where these changes came from, but of course, I want the explanation to work just in general, and not to be optimized for one thing we can see coming. Love that everyone's looking at this so critically, and if general consensus is that changing this section's logic is NOT preferred, we can go back to the original for now, and the drawing board for later. That's an option, too! (I still want the other changes sprinkled throughout the file for polish, though!) |
|
OK, @Jutanium @delucis @aFuzzyBear ... I'm "slotting" you in for another round! Can I suggest, DON'T revisit the comments above, and DO start reading at "Slots" to see, with fresh eyes and standing on its own, what you think?? |
|
Let's Get That Merged |
|
🥳 Let he who complains, open the next PR! |
Team effort, to revamp the slot material to address some slot issues raised in the community re: mixing with other frameworks.
Also, added some new touches re: our fancy new directives reference! (So... check that!)