Skip to content

docs: update Tailwind link#3554

Merged
ElianCodes merged 3 commits intomainfrom
ElianCodes-update-tailwind
Jun 23, 2023
Merged

docs: update Tailwind link#3554
ElianCodes merged 3 commits intomainfrom
ElianCodes-update-tailwind

Conversation

@ElianCodes
Copy link
Copy Markdown
Member

@ElianCodes ElianCodes commented Jun 22, 2023

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

@netlify
Copy link
Copy Markdown

netlify bot commented Jun 22, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 1e792bc
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6495b38ebb91850008bf35ae
😎 Deploy Preview https://deploy-preview-3554--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

sarah11918
sarah11918 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, @ElianCodes!

I added (had to commit because it wasn't part of your original edit) a tiny section for Tailwind, too, because I think it's good SEO and to have in the sidebar.

I just snagged from the actual Tailwind page, so this is more a suggestion than a "you must use this." Just felt like now that we're seeing so many projects use Tailwind, I'd EXPECT people to be on the styling page and actually see a subheading for Tailwind. I'm happy with this whenever you are, so take this as a suggestion, edit as you like, then yours to merge!

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jun 23, 2023
ElianCodes
ElianCodes commented Jun 23, 2023
View reviewed changes
Copy link
Copy Markdown
Member Author

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarah11918! I still left a couple suggestions I want your opinion on. Afterwards I'll merge

@ElianCodes ElianCodes merged commit a52460c into main Jun 23, 2023
@ElianCodes ElianCodes deleted the ElianCodes-update-tailwind branch June 23, 2023 15:09
@morinokami morinokami mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tailwind link goes to GitHub, doesn't make sense

2 participants

@ElianCodes @sarah11918