Skip to content

fix: removes wrong inline style info#3297

Merged
sarah11918 merged 2 commits intowithastro:mainfrom
ohansemmanuel:fix-inline-styles-info
May 19, 2023
Merged

fix: removes wrong inline style info#3297
sarah11918 merged 2 commits intowithastro:mainfrom
ohansemmanuel:fix-inline-styles-info

Conversation

@ohansemmanuel
Copy link
Copy Markdown
Contributor

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)
  • New or updated content

Description

Using define:vars in a <style> within a component markup still bundles the component styles, i.e., contrary to what's documented. Please refer to the #3165 for more details.

@netlify
Copy link
Copy Markdown

netlify bot commented May 19, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 87bdf4b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/6467b1c806c1a8000848f1f7
😎 Deploy Preview https://deploy-preview-3297--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label May 19, 2023
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @ohansemmanuel , and for confirming in the issue @Jothsa !

It's always helpful when an issue is discussed and verified before a PR comes in. Great team work! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Potentially misleading documented behaviour of define:vars

2 participants