Skip to content

Migrate React links to new documentation site#2993

Merged
yanthomasdev merged 3 commits intowithastro:mainfrom
TheOtterlord:react-dev
Apr 7, 2023
Merged

Migrate React links to new documentation site#2993
yanthomasdev merged 3 commits intowithastro:mainfrom
TheOtterlord:react-dev

Conversation

@TheOtterlord
Copy link
Copy Markdown
Member

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 5, 2023

Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit eb4e82a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/643002dc5f08bd0009a743d1
😎 Deploy Preview https://deploy-preview-2993--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Apr 5, 2023
Copy link
Copy Markdown
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that you included the translated version of the React docs as well! Although I noticed those differ quite a lot from the regular docs site

@TheOtterlord
Copy link
Copy Markdown
Member Author

I think some of it comes down to things still being translated. We could direct everything to the English site for the time being, and wait for the translated docs to become more complete?

@ElianCodes
Copy link
Copy Markdown
Member

@TheOtterlord Maybe that's better indeed, we can always come back later and update them!

### UI-Frameworks

Wenn dein Projekt ein [UI-Framework](/de/core-concepts/framework-components/) verwendet, können je nach Framework zusätzliche Einstellungen erforderlich sein. Weitere Informationen findest du in der TypeScript-Dokumentation deines Frameworks. ([Vue](https://vuejs.org/guide/typescript/overview.html#using-vue-with-typescript), [React](https://reactjs.org/docs/static-type-checking.html), [Preact](https://preactjs.com/guide/v10/typescript), [Solid](https://www.solidjs.com/guides/typescript))
Wenn dein Projekt ein [UI-Framework](/de/core-concepts/framework-components/) verwendet, können je nach Framework zusätzliche Einstellungen erforderlich sein. Weitere Informationen findest du in der TypeScript-Dokumentation deines Frameworks. ([Vue](https://vuejs.org/guide/typescript/overview.html#using-vue-with-typescript), [React](https://react-typescript-cheatsheet.netlify.app/docs/basic/setup), [Preact](https://preactjs.com/guide/v10/typescript), [Solid](https://www.solidjs.com/guides/typescript))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only link I'm not sure about, since this looks to be more of a community project than an official React resource. I'd like to get @sarah11918's thoughts on this before merging. All the other links seem to work well for me, thanks @TheOtterlord 🙌

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @yan-thomas ! When I follow the original (old) link, THEY THEMSELVES link to the React cheatsheet, so I think this is OK.

So take it away, Yan!

@sarah11918 sarah11918 added the typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. label Apr 7, 2023
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @TheOtterlord, LGTM 🚀

@yanthomasdev yanthomasdev merged commit 86cabdf into withastro:main Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants