fix: Fix InferGetStaticPropsType example#2944
Merged
Princesseuh merged 1 commit intomainfrom Mar 30, 2023
Merged
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
delucis
approved these changes
Mar 28, 2023
Member
delucis
left a comment
There was a problem hiding this comment.
LGTM! Will we ever auto-type Astro.params? I guess it’s less important and also using params in a component would still need the as so maybe best just to leave it.
yanthomasdev
approved these changes
Mar 28, 2023
Member
Author
Maybe! We still have this old accepted RFC to implement eventually https://github.com/withastro/roadmap/blob/main/proposals/0026-component-interface.md |
sarah11918
approved these changes
Mar 29, 2023
Member
sarah11918
left a comment
There was a problem hiding this comment.
Thanks, @Princesseuh! LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
Our tooling does not automatically uses
type Paramsto typeAstro.params. It never has, actually. Additionally, the two slash commands were in the wrong spot