Skip to content

Document verbatimModuleSyntax for TS 5.0 users#2891

Merged
delucis merged 4 commits intomainfrom
feat/ts-5.0-setting
Mar 23, 2023
Merged

Document verbatimModuleSyntax for TS 5.0 users#2891
delucis merged 4 commits intomainfrom
feat/ts-5.0-setting

Conversation

@Princesseuh
Copy link
Copy Markdown
Member

@Princesseuh Princesseuh commented Mar 20, 2023

What kind of changes does this PR include?

  • New or updated content

Description

In TypeScript 5.0, the latest version, the team deprecated importsNotUsedAsValue in favour of a boolean verbatimModuleSyntax. It does the same thing, it's just easier to use.

This PR updates our guidance to show both the new and old options.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 9228321
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/641ccafe4f00ad0007b80470
😎 Deploy Preview https://deploy-preview-2891--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Princesseuh Princesseuh added the Blocked Can't deal with because of a bug in Astro, or other blocking reason label Mar 20, 2023
@delucis delucis changed the title Replace importsNotUsedAsValues with verbatimModuleSyntax Document verbatimModuleSyntax as well as importsNotUsedAsValues Mar 23, 2023
@delucis delucis added improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) Blocked Can't deal with because of a bug in Astro, or other blocking reason and removed Blocked Can't deal with because of a bug in Astro, or other blocking reason labels Mar 23, 2023
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve our PR!

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🙌

@delucis delucis changed the title Document verbatimModuleSyntax as well as importsNotUsedAsValues Document verbatimModuleSyntax for TS 5.0 users Mar 23, 2023
@delucis delucis merged commit ff52edc into main Mar 23, 2023
@delucis delucis deleted the feat/ts-5.0-setting branch March 23, 2023 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants