Skip to content

Document new getStaticPaths type helpers#2765

Merged
sarah11918 merged 6 commits intomainfrom
getstaticpath-types
Mar 7, 2023
Merged

Document new getStaticPaths type helpers#2765
sarah11918 merged 6 commits intomainfrom
getstaticpath-types

Conversation

@matthewp
Copy link
Copy Markdown
Contributor

@matthewp matthewp commented Mar 1, 2023

What kind of changes does this PR include?

  • New or updated content

Description

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 1, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 96a1c8a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/640798bb20c1f20008e7eacc
😎 Deploy Preview https://deploy-preview-2765--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@matthewp matthewp mentioned this pull request Mar 1, 2023
Merged
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) labels Mar 1, 2023
@sarah11918 sarah11918 requested a review from delucis March 1, 2023 17:03
delucis
delucis reviewed Mar 1, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @matthewp! Left a couple of suggestions.

matthewp and others added 4 commits March 3, 2023 09:43
@matthewp @delucis
Update src/content/docs/en/guides/typescript.mdx
3881eb3 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@matthewp @delucis
Update src/content/docs/en/guides/typescript.mdx
ffafde5 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@matthewp @delucis
Update src/content/docs/en/guides/typescript.mdx
a38499c 
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
@delucis
Merge branch 'main' into getstaticpath-types
f4a0665
delucis
delucis approved these changes Mar 7, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready when 2.1 is released!

@sarah11918 sarah11918 merged commit 7f732d7 into main Mar 7, 2023
@sarah11918 sarah11918 deleted the getstaticpath-types branch March 7, 2023 20:06
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. label Jun 22, 2023
@McFlyPartages McFlyPartages mentioned this pull request Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delucis delucis delucis approved these changes

Assignees

@delucis delucis

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matthewp @delucis @sarah11918