Minor fix to file extensions in cypress section#2762
Merged
Jutanium merged 1 commit intowithastro:mainfrom Mar 1, 2023
adrian-burkhart:patch-1
Merged
Minor fix to file extensions in cypress section#2762Jutanium merged 1 commit intowithastro:mainfrom adrian-burkhart:patch-1
Jutanium merged 1 commit intowithastro:mainfrom
adrian-burkhart:patch-1
Conversation
`npm run cypress` failed for me, because the spec file was named `index.spec.ts`, but cypress was looking for `index.cy.ts`. I also changed some file extensions to `.js` to make it more consistent.
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
|
Great catch, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of changes does this PR include?
Description
npm run cypressfailed for me, because the spec file the guide had me create was namedindex.spec.ts, but cypress was looking forindex.cy.ts. Therefore, I updated the guide to state that you should create anindex.cy.tsfile instead..tsextensions in some places, and.jsextensions in others. Therefore, I changed the.tsextensions to.jsto make it more consistent.