Skip to content

[i18nIgnore] feat: Correct TypeScript spelling#2720

Merged
sarah11918 merged 5 commits intowithastro:mainfrom
exposir:main
Feb 23, 2023
Merged

[i18nIgnore] feat: Correct TypeScript spelling#2720
sarah11918 merged 5 commits intowithastro:mainfrom
exposir:main

Conversation

@exposir
Copy link
Copy Markdown
Contributor

@exposir exposir commented Feb 23, 2023 •
edited
Loading

What kind of changes does this PR include?

  • Minor content fixes (broken links, typos, etc.)

Description

  • Typescript -> TypeScript

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 23, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit bf73e55
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63f78b68e353900007b5ff7c
😎 Deploy Preview https://deploy-preview-2720--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Feb 23, 2023
liruifengv
liruifengv requested changes Feb 23, 2023
View reviewed changes
@sarah11918 sarah11918 changed the title feat: Correct TypeScript spelling [i18nIgnore] feat: Correct TypeScript spelling Feb 23, 2023
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Feb 23, 2023

Thanks for this @exposir ! I'm going to go ahead and commit @liruifengv 's suggestions for you so that we can merge this right away! We appreciate your attention to detail, and taking the time to make a contribution. Welcome to Team Docs! 🥳

sarah11918 and others added 3 commits February 23, 2023 09:28
@sarah11918 @liruifengv
revert correction of spelling when it's supposed to be wrong as a tea…
cfe68d2 
…ching example

Co-authored-by: 李瑞丰 <liruifeng1024@gmail.com>
@sarah11918 @liruifengv
fix JavaScript spelling while we're here!
4644e3f 
Co-authored-by: 李瑞丰 <liruifeng1024@gmail.com>
@sarah11918
Merge branch 'main' into main
2fcc9cc
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Feb 23, 2023

Also follow up that yes, as @liruifengv pointed out, this page also needs updating Javascript/Typescript - > JavaScript/TypeScript https://docs.astro.build/zh-tw/guides/testing/

That can be a new PR if you'd like to make another one, @exposir ! (Or whoever gets there firs!t!) 😄

@sarah11918 sarah11918 added the typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text. label Feb 23, 2023
liruifengv
liruifengv reviewed Feb 23, 2023
View reviewed changes
@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Feb 23, 2023

Also follow up that yes, as @liruifengv pointed out, this page also needs updating Javascript/Typescript - > JavaScript/TypeScript https://docs.astro.build/zh-tw/guides/testing/

That can be a new PR if you'd like to make another one, @exposir ! (Or whoever gets there firs!t!) 😄

And zh-cn, etc

@sarah11918 @liruifengv
liruifengv found another one!
bf73e55 
Co-authored-by: 李瑞丰 <liruifeng1024@gmail.com>
@liruifengv
Copy link
Copy Markdown
Member

liruifengv commented Feb 23, 2023

Awesome!

@sarah11918 sarah11918 merged commit 3960365 into withastro:main Feb 23, 2023
@liruifengv liruifengv mentioned this pull request Feb 26, 2023
Merged
@morinokami morinokami mentioned this pull request Sep 23, 2023
Merged
@McFlyPartages McFlyPartages mentioned this pull request Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@liruifengv liruifengv liruifengv approved these changes

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! typo/link/grammar - quick fix! Quick fix for a link, typo, grammar/syntax error etc. Doesn't significantly change meaning of text.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@exposir @sarah11918 @liruifengv