Skip to content

docs: add testing guide for cypress#2689

Merged
Jutanium merged 7 commits intowithastro:mainfrom
bandantonio:add-cypress-to-testing-guide
Feb 27, 2023
Merged

docs: add testing guide for cypress#2689
Jutanium merged 7 commits intowithastro:mainfrom
bandantonio:add-cypress-to-testing-guide

Conversation

@bandantonio
Copy link
Copy Markdown
Contributor

@bandantonio bandantonio commented Feb 19, 2023

What kind of changes does this PR include?

  • New or updated content

Description

@netlify
Copy link
Copy Markdown

netlify bot commented Feb 19, 2023 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 6a22d6a
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63fb36d1512ae30008d33e32
😎 Deploy Preview https://deploy-preview-2689--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Feb 20, 2023
Jutanium
Jutanium reviewed Feb 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jutanium Jutanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Super glad to add Cypress to these docs. Added a few edits/comments - let me know if you have any questions!

@bandantonio bandantonio requested a review from Jutanium February 20, 2023 23:48
@bandantonio
Copy link
Copy Markdown
Contributor Author

bandantonio commented Feb 21, 2023 •
edited
Loading

@Jutanium Please don't commit the suggestions and don't merge the PR yet.
I have all the changes (marked with thumbs up for clarity) applied locally, but haven't pushed them yet. I was waiting for your reply related to the config file. I will update the PR in an hour or so.
@sarah11918 fyi

@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Feb 21, 2023

Thanks! I will wait for an explicit go-ahead from you before I even START my read-through!

@bandantonio bandantonio force-pushed the add-cypress-to-testing-guide branch from dc452cb to 6273e81 Compare February 21, 2023 18:41
@bandantonio
Copy link
Copy Markdown
Contributor Author

bandantonio commented Feb 21, 2023

@sarah11918 Fell free to proceed with your review

sarah11918
sarah11918 reviewed Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, @bandantonio and @Jutanium!!

I've left some suggestions (many non-blocking!) after a read through finally of this one myself. Dan, I trust you to merge based on my comments when you both are happy! 🥳

Jutanium
Jutanium reviewed Feb 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Jutanium Jutanium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with these two changes!

sarah11918
sarah11918 reviewed Feb 26, 2023
View reviewed changes
@bandantonio bandantonio deleted the add-cypress-to-testing-guide branch February 27, 2023 19:15
@morinokami morinokami mentioned this pull request Sep 23, 2023
Merged
@McFlyPartages McFlyPartages mentioned this pull request Jan 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

+1 more reviewer

@Jutanium Jutanium Jutanium left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@Jutanium Jutanium

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expand Testing Guides to include Cypress

3 participants

@bandantonio @sarah11918 @Jutanium