Skip to content

[Content collections] z.object wrapper for schemas#2335

Merged
bholmesdev merged 4 commits intomainfrom
edit/schema-object-requirement
Jan 12, 2023
Merged

[Content collections] z.object wrapper for schemas#2335
bholmesdev merged 4 commits intomainfrom
edit/schema-object-requirement

Conversation

@bholmesdev
Copy link
Copy Markdown
Contributor

What kind of changes does this PR include?

  • New or updated content

Description

  • Add z.object wrapper around schema definitions. This is now a required wrapper!

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 10, 2023

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit decf4aa
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/63bd8f33461c40000ad0b64f
😎 Deploy Preview https://deploy-preview-2335--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Ben! Left a couple of nits but otherwise LGTM. (Helpfully my nits are in the wrong places thanks to GitHub’s UI.)

Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Ben! Leaving to Chris for the final say!

@sarah11918 sarah11918 added the improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes) label Jan 10, 2023
Copy link
Copy Markdown
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That’s a wrap!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improve or update documentation Enhance / update existing documentation (e.g. add example, improve description, update for changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants