[troubleshooting] remove suggested workaround re: executing inline scripts#2255
Merged
sarah11918 merged 1 commit intomainfrom Dec 29, 2022
Merged
[troubleshooting] remove suggested workaround re: executing inline scripts#2255sarah11918 merged 1 commit intomainfrom
sarah11918 merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
delucis
approved these changes
Dec 29, 2022
Member
delucis
left a comment
There was a problem hiding this comment.
LGTM — long term we do need a proper answer to this, but this will do for now.
(I was kind of unsure about removing as this workaround does work for some people so isn’t totally unhelpful, but probably not right for docs.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2150 (The documentation issue; the greater conversation is ongoing elsewhere.)
As per @delucis suggestion and @matthewp approval, removes a problematic workaround that does not work in every case, and instead just leaves the suggestion to update your CSP.
(Note: eventually error messages will make their way to the Error Reference page. But, at least this removes potentially harmful advice for now.)