Skip to content

feat: document the jsx whitespace change#14076

Merged
ArmandPhilippot merged 2 commits into
v7from
feat/jsx-whitespace-default
Jun 18, 2026
Merged

feat: document the jsx whitespace change#14076
ArmandPhilippot merged 2 commits into
v7from
feat/jsx-whitespace-default

Conversation

@Princesseuh

@Princesseuh Princesseuh commented Jun 16, 2026

Copy link
Copy Markdown
Member

Description (required)

Docs for withastro/astro#16965

@netlify

netlify Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ Deploy Preview for astro-docs-2 failed. Why did it fail? →

Name Link
🔨 Latest commit 8e47b79
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6a316a8baf24a00008b5525c

@Princesseuh Princesseuh mentioned this pull request Jun 16, 2026
Merged
@astrobot-houston

astrobot-houston commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v7.mdx Localization changed, will be marked as complete.
en/reference/configuration-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions

github-actions Bot commented Jun 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

ArmandPhilippot
ArmandPhilippot reviewed Jun 16, 2026
View reviewed changes

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Erika!
Overall the content looks good but I'm not sure about the organization and the first sentence in "What should I do?". See my suggestion, and feel free to make edits if you don't like some things!

Comment thread src/content/docs/en/guides/upgrade-to/v7.mdx Outdated
@ArmandPhilippot ArmandPhilippot added this to the v7 milestone Jun 16, 2026
@ArmandPhilippot ArmandPhilippot added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) 7.0 labels Jun 16, 2026
@ArmandPhilippot ArmandPhilippot mentioned this pull request Jun 17, 2026
Merged
@Princesseuh @ArmandPhilippot
Update src/content/docs/en/guides/upgrade-to/v7.mdx
0a6b81d 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
ArmandPhilippot
ArmandPhilippot approved these changes Jun 18, 2026
View reviewed changes

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the preview, LGTM! Thank you!

yanthomasdev
yanthomasdev approved these changes Jun 18, 2026
View reviewed changes

@yanthomasdev yanthomasdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work!

@ArmandPhilippot ArmandPhilippot merged commit 77fb0bc into v7 Jun 18, 2026
9 checks passed
@ArmandPhilippot ArmandPhilippot deleted the feat/jsx-whitespace-default branch June 18, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewp matthewp matthewp approved these changes
@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes
@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees

No one assigned

Labels

7.0 merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

v7

Development

Successfully merging this pull request may close these issues.

5 participants

@Princesseuh @astrobot-houston @matthewp @ArmandPhilippot @yanthomasdev