Skip to content

feat(fonts): include subset field in fontData from astro:assets#14018

Closed
florian-lefebvre wants to merge 27 commits into
v7from
flue/fix-16951
Closed

feat(fonts): include subset field in fontData from astro:assets#14018
florian-lefebvre wants to merge 27 commits into
v7from
flue/fix-16951

Conversation

@florian-lefebvre

@florian-lefebvre florian-lefebvre commented Jun 8, 2026

Copy link
Copy Markdown
Member

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

For Astro version: 6.5. See astro PR #16996.

@florian-lefebvre florian-lefebvre mentioned this pull request Jun 8, 2026
Merged
@netlify

netlify Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit a21e19e
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/6a26c478682fdc0008f7d587
😎 Deploy Preview https://deploy-preview-14018--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston

astrobot-houston commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/cms/contentful.mdx Source changed, localizations will be marked as outdated.
en/guides/cms/sanity.mdx Source changed, localizations will be marked as outdated.
en/guides/cms/zero.mdx Source added, will be tracked.
en/guides/configuring-astro.mdx Source changed, localizations will be marked as outdated.
en/guides/deploy/github.mdx Source changed, localizations will be marked as outdated.
en/guides/images.mdx Source changed, localizations will be marked as outdated.
en/guides/integrations-guide/sitemap.mdx Source changed, localizations will be marked as outdated.
en/guides/styling.mdx Source changed, localizations will be marked as outdated.
en/guides/syntax-highlighting.mdx Source changed, localizations will be marked as outdated.
en/guides/typescript.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v5.mdx Source changed, localizations will be marked as outdated.
en/reference/content-loader-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/errors/invalid-get-static-path-param.mdx Source changed, localizations will be marked as outdated.
en/reference/errors/invalid-get-static-paths-entry.mdx Source changed, localizations will be marked as outdated.
en/reference/errors/invalid-get-static-paths-return.mdx Source changed, localizations will be marked as outdated.
en/reference/modules/astro-assets.mdx Source changed, localizations will be marked as outdated.
en/reference/modules/astro-middleware.mdx Source changed, localizations will be marked as outdated.
en/reference/modules/astro-zod.mdx Source changed, localizations will be marked as outdated.
en/tutorial/2-pages/1.mdx Source changed, localizations will be marked as outdated.
es/guides/cms/sanity.mdx Localization changed, will be marked as complete.
fr/guides/cms/sanity.mdx Localization changed, will be marked as complete.
fr/reference/experimental-flags/advanced-routing.mdx Localization changed, will be marked as complete.
ja/basics/layouts.mdx Localization changed, will be marked as complete.
ja/guides/build-with-ai.mdx Localization changed, will be marked as complete.
ja/guides/data-fetching.mdx Localization added, will be marked as complete.
ja/guides/deploy/github.mdx Localization changed, will be marked as complete.
ja/guides/integrations-guide/mdx.mdx Localization changed, will be marked as complete.
ja/guides/markdown-content.mdx Localization added, will be marked as complete.
ja/guides/server-islands.mdx Localization changed, will be marked as complete.
ja/guides/syntax-highlighting.mdx Localization changed, will be marked as complete.
ja/guides/upgrade-to/v6.mdx Localization changed, will be marked as complete.
ja/tutorial/4-layouts/2.mdx Localization changed, will be marked as complete.
ko/getting-started.mdx Localization changed, will be marked as complete.
ko/guides/cms/contentful.mdx Localization changed, will be marked as complete.
ko/guides/cms/sanity.mdx Localization changed, will be marked as complete.
ko/guides/configuring-astro.mdx Localization changed, will be marked as complete.
ko/guides/deploy/github.mdx Localization changed, will be marked as complete.
ko/guides/images.mdx Localization changed, will be marked as complete.
ko/guides/integrations-guide/sitemap.mdx Localization changed, will be marked as complete.
ko/guides/media/imagekit.mdx Localization added, will be marked as complete.
ko/guides/styling.mdx Localization changed, will be marked as complete.
ko/guides/syntax-highlighting.mdx Localization changed, will be marked as complete.
ko/guides/typescript.mdx Localization changed, will be marked as complete.
ko/guides/upgrade-to/v5.mdx Localization changed, will be marked as complete.
ko/reference/content-loader-reference.mdx Localization changed, will be marked as complete.
ko/reference/errors/invalid-get-static-path-param.mdx Localization changed, will be marked as complete.
ko/reference/errors/invalid-get-static-paths-entry.mdx Localization changed, will be marked as complete.
ko/reference/errors/invalid-get-static-paths-return.mdx Localization changed, will be marked as complete.
ko/reference/experimental-flags/advanced-routing.mdx Localization changed, will be marked as complete.
ko/reference/image-service-reference.mdx Localization changed, will be marked as complete.
ko/reference/modules/astro-middleware.mdx Localization changed, will be marked as complete.
ko/reference/modules/astro-zod.mdx Localization changed, will be marked as complete.
ko/tutorial/2-pages/1.mdx Localization changed, will be marked as complete.
pt-br/guides/cms/sanity.mdx Localization changed, will be marked as complete.
zh-cn/guides/cms/sanity.mdx Localization changed, will be marked as complete.
zh-tw/getting-started.mdx Localization changed, will be marked as complete.
zh-tw/guides/configuring-astro.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

ArmandPhilippot
ArmandPhilippot reviewed Jun 8, 2026
View reviewed changes

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to update one type, otherwise LGTM. Thanks!
My other comments are mostly nitpicks (version?) and things I don't necessarily have the answer yet... 😄

Comment thread src/content/docs/en/reference/modules/astro-assets.mdx Outdated
Comment thread src/content/docs/en/reference/modules/astro-assets.mdx Outdated
Comment thread src/content/docs/en/reference/modules/astro-assets.mdx Outdated
florian-lefebvre
florian-lefebvre commented Jun 8, 2026
View reviewed changes
Comment thread src/content/docs/en/reference/modules/astro-assets.mdx Outdated
@florian-lefebvre florian-lefebvre changed the base branch from main to v7 June 8, 2026 13:33
@florian-lefebvre florian-lefebvre changed the base branch from v7 to main June 8, 2026 13:33
ArmandPhilippot and others added 23 commits June 8, 2026 15:35
@ArmandPhilippot @thomasbnt @florian-lefebvre
i18n(fr): update experimental-flags/advanced-routing.mdx (#13969)
8e2e14b 
Co-authored-by: Thomas Bonnet <thomasbnt@protonmail.com>
@morinokami @florian-lefebvre
i18n(ja): update build-with-ai.mdx (#13972)
db6d7cc
@Yusaku01 @morinokami @florian-lefebvre
i18n(ja): update guides deploy github.mdx (#13976)
6b8cafe 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@jsparkdev @ArmandPhilippot @florian-lefebvre
i18n(ko-KR): update advanced-routing.mdx (#13964)
27ecdc7 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@jsparkdev @ArmandPhilippot @florian-lefebvre
i18n(ko-KR): update images, image-service-reference, add `imageki…
625a502 
…t` (#13965)

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@samppis @ArmandPhilippot @florian-lefebvre
Add Zero CMS guide (#13963)
a312d77 
Co-authored-by: Samuli Linnankoski <samuli.linnankoski@luotocompany.fi>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@kailauber @ArmandPhilippot @florian-lefebvre
fix(en): capitalize TypeScript and JavaScript brand names (#13981)
068fd73 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@kailauber @ArmandPhilippot @florian-lefebvre
docs(en): fix doubled "the the" typo in images guide (#13979)
bc455d7 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@kailauber @ArmandPhilippot @florian-lefebvre
docs(en): remove duplicate astro language tag in two code fences (#…
6251b30 
…13980)

Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@astrobot-houston @delucis
@ArmandPhilippot @florian-lefebvre
ci: update error reference docs (#13989)
2ca7b1e 
Co-authored-by: delucis <357379+delucis@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@muhaimincs @ArmandPhilippot @florian-lefebvre
Correct Vite config syntax in styling.mdx (#13988)
c5aaa25 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@vrabe @ArmandPhilippot @florian-lefebvre
fix: fix github url in guides/deploy/github.mdx (#13991)
a9196b8 
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@vrabe @yanthomasdev @florian-lefebvre
i18n(zh-tw): update guides/configuring-astro.mdx (#13992)
7b5bde3 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@morinokami @yanthomasdev @florian-lefebvre
i18n(ja): update server-islands.mdx (#13973)
f1cbb8a 
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@McVyp @yanthomasdev @florian-lefebvre
fix: remove broken Balanced Chef theme link from Sanity page [i18nIgn…
3a09ad3 
…ore] (#13962)

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
@morinokami @florian-lefebvre
i18n(ja): add data-fetching.mdx (#13971)
62f13d3
@morinokami @florian-lefebvre
i18n(ja): add markdown-content.mdx and update mdx.mdx (#13970)
14c65d9
@morinokami @florian-lefebvre
i18n(ja): update syntax-highlighting.mdx (#13975)
1ea83dd
@jsparkdev @morinokami @florian-lefebvre
i18n(ko-KR): update getting-started, contentful, github, `2-pag…
943430d 
…es/1.mdx` (#13999)

Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@vrabe @morinokami @florian-lefebvre
i18n(zh-tw): update getting-started.mdx (#13998)
02102c4 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@jsparkdev @morinokami @florian-lefebvre
i18n(ko-KR): update styling.mdx and errors/ (#14001)
4dac6ae 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@jsparkdev @morinokami @florian-lefebvre
i18n(ko-KR): capitalize TypeScript and JavaScript brand names (#14000)
8da1b88 
Co-authored-by: Shinya Fujino <shf0811@gmail.com>
@astrobot-houston @HiDeoo
@ArmandPhilippot @florian-lefebvre
ci: update docs contributors (#14009)
d8b5b81 
Co-authored-by: HiDeoo <494699+HiDeoo@users.noreply.github.com>
Co-authored-by: Armand Philippot <59021693+ArmandPhilippot@users.noreply.github.com>
@florian-lefebvre florian-lefebvre changed the base branch from main to v7 June 8, 2026 13:36
@github-actions github-actions Bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 8, 2026
@florian-lefebvre florian-lefebvre deleted the flue/fix-16951 branch June 8, 2026 13:37
@florian-lefebvre florian-lefebvre mentioned this pull request Jun 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot left review comments

Assignees

No one assigned

Labels

i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.