Add docs for route caching CDN providers#13937
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thank you! Overall, this LGTM. I left a few comments/suggestions, but nothing really blocking. They're mostly nitpicking either to improve the readability (shorter sentences) or because I wonder if we are documenting implementation details...
- Document the Netlify, Vercel, and Cloudflare CDN cache providers (manual opt-in; Cloudflare private beta) in the caching guide - Add an astro/cache/provider-utils reference section and the setHeaders(options, request) signature - Use file-based routing patterns ([...rest]) instead of unsupported globs
88d7fe8 to
2c2d4ea
Compare
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
Preview deployment ✅ Deployment complete!
|
|
@ArmandPhilippot I've stacked this on your PR and could just merge it in to that if it's easier |
There was a problem hiding this comment.
I have two nits (adding links could help users), but this LGTM! Thanks!
While reviewing, I noticed we don't have any code snippets in the Astro.cache reference... Do you want to add some? Otherwise, feel free to merge into my PR and I'll see to add some based on the guide and your changesets!
| <Since pkg="@astrojs/cloudflare" v="14.0.0" /> | ||
| </p> | ||
|
|
||
| :::caution[Private beta] |
There was a problem hiding this comment.
Do we know when this will leave the private beta? Is it simply an update to the Cloudflare package, or does it require a change to Astro's code? What I mean is, if it's just a package update (ie. renovate...), we might forget to update the documentation. So, I just want to know if this is something we need to monitor or not.
There was a problem hiding this comment.
It's a Cloudflare platform thing, out of our hands. I'm monitoring it and will update the docs.
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Thanks, @ArmandPhilippot. I've applied your suggestions and will merge. I'll follow up by pushing code snippets to your branch. |
Description (required)
Adds docs for the three new experimental CDN cache providers. I've added the docs for all providers to the existing experiemntal flag page, rather than the adapter pages.
Related issues & labels (optional)
Code PR: withastro/astro#16335
For Astro version:
6.4. See astro PR withastro/astro#16335.