feat: docs for pluggable Markdown processors#13919
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Great work, Erika! I left a few comments, mostly nits and two questions where we now show how to do something with @astrojs/markdown-remark but without any equivalent for Sätteri.
And, as far as I can tell, the broken links should be fixed once your core PR is merged!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
b13ef9c to
543fb80
Compare
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Thanks for the updates, Erika! I left a few suggestions (except the highlighting, this is mostly nitpicking). LGTM!
If you don't mind, I'll update the branch for #13943 and merge it in your PR. This way, we can fix link errors and ensure that each check is successful before the merge!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
What...
Alright, I don't want to bother you with this again. I'll push the fix directly to your branch, merge main into it then the CI PR. Then, you can yell at me if I broke anything. 😄 |
|
ha, that's a new one. That's unfortunate |
Co-authored-by: delucis <357379+delucis@users.noreply.github.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu>
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Perfect, everything is green and I've double-checked I don't think GitHub broke more things!
|
I'm merging this into an umbrella PR, so we'll only have one PR to worry about tomorrow. |
Description (required)
Docs for
withastro/astro#16149withastro/astro#16848