feat: stable logger#13907
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
Already! Ahah, you move too fast for the French reviewers... I guess I can close #13830 😅
Speaking of that, the link error is because of the Korean translation. We usually delete the translations as well when we stabilize an experimental feature.
I know the content hasn't changed much... maybe we should consider renaming the translation and using a Lunaria directive in a case like this. But, I believe Junseong is able to easily browse the Git history to recover its translation so we can remove it for now.
I left a few suggestions to be consistent with our other references (a bit more verbose in some places, functions notation).
Is Astro.logger particularly useful with custom loggers? If so, maybe we should add a link to /en/reference/api-reference/#logger to improve its discoverability. If not, no change needed!
Also, I noticed we now have loggerConfig in SSRManifest. We'll need a new section in https://docs.astro.build/en/reference/integrations-reference/#ssrmanifest
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
It's the whole point! Ahahaha. Dufus me that I completely overlooked this important connection. The important thing is that the runtime APIs are always at user's disposal regardless of a custom logger, but with a custom logger users have more control. My last commit added a small paragraph with the link |
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
There was a problem hiding this comment.
I was double checking, and I think this is almost ready.
- In the
SSRManifestreference, we need a section forloggerConfig. And, now we have a section for log levels, we should update theSSRManifest.logLeveldescription with a link to that section. - I left a question about log levels because
debugandsilentare also available but we do not explain how they differ.
Edit: I found another place https://docs.astro.build/en/reference/modules/astro-config/#imports-from-astroconfig we'll need to add logHandlers there. A good occasion to create a link to the Logger API there!
| }); | ||
| ``` | ||
|
|
||
| ### `logHandlers.compose` |
There was a problem hiding this comment.
I missed this one, parentheses for consistency:
| ### `logHandlers.compose()` |
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
|
Ah, right, my French PR finally got merged. We'll need to remove it to fix the failing check! |
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| 🚫 Deployment cancelled View logs |
docs | 9f23de1 | Jun 09 2026, 02:19 PM |
🚀 Deploying Preview to Cloudflare 🚀Preview Deployments by commit
|
Description (required)
This PR adds documentation for the logger APIs, which will be stable soon
For Astro version:
7.0.0. See astro PR #16745.