Small fixes in various files (highlighting, indent, zod, links, etc.)#13341
Small fixes in various files (highlighting, indent, zod, links, etc.)#13341sarah11918 merged 2 commits intov6from
Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
|
|
||
| const svg = await satori( | ||
| <div style={{ color: "black" }}>hello, world</div>, | ||
| html`<div style="color: black;">hello, world</div>`, |
There was a problem hiding this comment.
Is this how Satori works? This is the only thing that looks odd to me, so just double checking this is what you intended!
There was a problem hiding this comment.
Yes, this is expected. But this is not Satori itself, this is an utility made by Nate (https://github.com/natemoo-re/satori-html) that allows to write html inside an html helper using backticks.
The previous example was the right syntax using Satori alone, but we can't have a <div> in a .ts file and Astro doesn't support .tsx endpoints. So we need an additional helper to write HTML as string instead.
sarah11918
left a comment
There was a problem hiding this comment.
Just one thing that I wanted to confirm is as intended, otherwise, great catches Armand! 🎉
Description (required)
I was reviewing v6 docs, including pages not updated in the v6 branch, to check that we haven't miss anything. Except one Zod import and one content collection id/slug error, this is mostly what I caught while scanning the pages. (but I'm not done yet)
astro-courses.mdx: The SupportSquid forum is no longer under a subdomain. Even if there is a redirection, might be better to update the link. (closes Astro Support Squid’ url broken ( `get.supportsquid.ink` redirects to a domain parking page ) #13054)content-collections.mdx:fonts.mdx:.tsx(closes Conflicting TSX Endpoint support #13324)fetch()call to reduce the horizontal scroll on small devicesframework-components.mdx: fixes a shift in highlighted linesimages.mdx:coverpropertypost.slug/post.id)migrate-to-astro/*: fixes an unclosed<style />tag and the indentationtroubleshooting.mdx: updates the Roadmap link, there is a redirection but better to be safe by updating the link!Related issues & labels (optional)