Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ascorbic
left a comment
There was a problem hiding this comment.
This is good and clear to me
|
One thing I would change maybe is: rename driver.options to driver.config to stay consistent with image services and font providers |
|
Watched this on Talking and Doc'ing. Thank you! |
|
T&D |
…thastro/docs into feat/sessions-drivers-changes
ArmandPhilippot
left a comment
There was a problem hiding this comment.
This looks great, Florian! 🙌🏽 I left two suggestions regarding the new sentences in "session driver config" and "session driver implementation". Maybe it's just me, but when the first words repeat the title, it sounds strange to me. Feel free to adapt them!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
sarah11918
left a comment
There was a problem hiding this comment.
Looks fantastic @florian-lefebvre ! Just a few nit thoughts from me, but this is pretty good to go! I'm happy when you're happy, but we can't merge until this is released in the next alpha.
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
|
I'll add |
Description (required)
Related issues & labels (optional)
For Astro version:
6.0. See astro PR #15006.