Skip to content

[v6] disallow number in getStaticPaths params#12608

Merged
florian-lefebvre merged 10 commits intowithastro:v6from
ocavue-forks:ocavue/rm-static-path-num
Oct 27, 2025
Merged

[v6] disallow number in getStaticPaths params#12608
florian-lefebvre merged 10 commits intowithastro:v6from
ocavue-forks:ocavue/rm-static-path-num

Conversation

@ocavue
Copy link
Copy Markdown
Contributor

@ocavue ocavue commented Oct 23, 2025 •
edited
Loading

Description (required)

v6 docs for the upcoming breaking change introduced in withastro/astro#14586

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@netlify
Copy link
Copy Markdown

netlify bot commented Oct 23, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 52a7271
🔍 Latest deploy log https://app.netlify.com/projects/astro-docs-2/deploys/68ff2c3bda366800085e305c
😎 Deploy Preview https://deploy-preview-12608--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Oct 23, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/upgrade-to/v6.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@ocavue ocavue marked this pull request as ready for review October 23, 2025 13:19
@ocavue ocavue mentioned this pull request Oct 23, 2025
Merged
florian-lefebvre
florian-lefebvre reviewed Oct 24, 2025
View reviewed changes
@sarah11918 sarah11918 added the 6.0 label Oct 24, 2025
sarah11918
sarah11918 reviewed Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of Florian's suggestions look great to me! (I did do some tiny polishing edits)

ocavue and others added 5 commits October 25, 2025 01:32
@ocavue @florian-lefebvre
Update src/content/docs/en/guides/upgrade-to/v6.mdx
be8e800 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@ocavue @florian-lefebvre
Update src/content/docs/en/guides/upgrade-to/v6.mdx
88db8d7 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@ocavue @florian-lefebvre
Update src/content/docs/en/guides/upgrade-to/v6.mdx
31e2a40 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@ocavue @florian-lefebvre
Update src/content/docs/en/guides/upgrade-to/v6.mdx
a6b0ed5 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
@ocavue @florian-lefebvre
Update src/content/docs/en/guides/upgrade-to/v6.mdx
9654590 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
florian-lefebvre
florian-lefebvre approved these changes Oct 24, 2025
View reviewed changes
@ocavue @florian-lefebvre
Update src/content/docs/en/guides/upgrade-to/v6.mdx
6cd018b 
Co-authored-by: Florian Lefebvre <contact@florian-lefebvre.dev>
yanthomasdev
yanthomasdev approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ArmandPhilippot
ArmandPhilippot approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@ArmandPhilippot ArmandPhilippot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two nits (indentation and link format), otherwise LGTM!

ocavue and others added 2 commits October 25, 2025 04:22
@ocavue @ArmandPhilippot
Update src/content/docs/en/guides/upgrade-to/v6.mdx
476e2bd 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@ocavue @ArmandPhilippot
Update src/content/docs/en/guides/upgrade-to/v6.mdx
0b95962 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
bjohansebas
bjohansebas approved these changes Oct 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sarah11918
sarah11918 approved these changes Oct 27, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me! Thank you, and welcome to Team Docs @ocavue ! 🥳

@florian-lefebvre florian-lefebvre merged commit 5d03bde into withastro:v6 Oct 27, 2025
6 checks passed
@sarah11918 sarah11918 added this to the v6.0.0 docs milestone Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@ArmandPhilippot ArmandPhilippot ArmandPhilippot approved these changes

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

+1 more reviewer

@bjohansebas bjohansebas bjohansebas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.0

Projects

None yet

Milestone

v6.0.0 docs

Development

Successfully merging this pull request may close these issues.

7 participants

@ocavue @astrobot-houston @sarah11918 @ArmandPhilippot @yanthomasdev @florian-lefebvre @bjohansebas