Conversation
✅ Deploy Preview for astro-docs-2 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Lunaria Status Overview🌕 This pull request will trigger status changes. Learn moreBy default, every PR changing files present in the Lunaria configuration's You can change this by adding one of the keywords present in the Tracked Files
Warnings reference
|
ArmandPhilippot
left a comment
There was a problem hiding this comment.
A small nit, otherwise this looks good. And I couldn't find any occurrences elsewhere in the docs. So yes, I think there is nothing else to update!
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
sarah11918
left a comment
There was a problem hiding this comment.
These look great! As you'll notice, because these are potentially "silent killers" hiding in waiting, deprecated a long time ago but then just been hanging around... I was a little more forceful in describing that they need to be removed for the specific reason that they'll now cause errors vs just saying they're not necessary anymore. These feel like things that could secretly have been hiding in people's projects for a long time if they exist, so maybe worth being a bit extra here.
|
|
||
| <SourcePR number="14462" title="feat: clean deprecated APIs"/> | ||
|
|
||
| In Astro 4.0, the `handleForms` prop of the `<ClientRouter />` component was deprecated. |
There was a problem hiding this comment.
I was about to correct this, thinking you surely meant it was deprecated in 5.0, but nope! It has stuck around! 😂
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
sarah11918
left a comment
There was a problem hiding this comment.
One tiny more suggestion in keeping with the others, but LGTM!
Co-authored-by: Sarah Rainsberger <5098874+sarah11918@users.noreply.github.com>
Co-authored-by: Sarah Rainsberger 5098874+sarah11918@users.noreply.github.com
Description (required)
I don't think docs need to be updated elsewhere because the things getting deprecated were already not documented anymore
Related issues & labels (optional)
For Astro version:
6.0. See astro PR #14462.