Skip to content

Update mention about script processing behavior in JSX expression#10656

Merged
MoustaphaDev merged 5 commits intomainfrom
update-jsx-script-mention
Feb 11, 2025
Merged

Update mention about script processing behavior in JSX expression#10656
MoustaphaDev merged 5 commits intomainfrom
update-jsx-script-mention

Conversation

@MoustaphaDev
Copy link
Copy Markdown
Member

@MoustaphaDev MoustaphaDev commented Jan 8, 2025 •
edited
Loading

Description (required)

Since renderScript was turned on by default in Astro 5, rules of processing scripts are consistent, regardless of the context the script is written in.

I added an example to show what it unlocks (todo)

Related issues & labels (optional)

@astrobot-houston
Copy link
Copy Markdown
Contributor

astrobot-houston commented Jan 8, 2025 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/guides/client-side-scripts.mdx Source changed, localizations will be marked as outdated.
en/guides/upgrade-to/v5.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@netlify
Copy link
Copy Markdown

netlify bot commented Jan 8, 2025 •
edited
Loading

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 6407410
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67aa8bd47f740f00080df39d
😎 Deploy Preview https://deploy-preview-10656--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sarah11918 sarah11918 added the merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) label Jan 8, 2025
@sarah11918
Copy link
Copy Markdown
Member

sarah11918 commented Jan 8, 2025

Thanks for the update!

Also a related comment here re: what we might need in the compiler PR! withastro/compiler#1057 (comment)

@MoustaphaDev MoustaphaDev mentioned this pull request Jan 10, 2025
Merged
@MoustaphaDev MoustaphaDev marked this pull request as ready for review January 10, 2025 16:14
sarah11918
sarah11918 approved these changes Jan 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just reordered some stuff on the upgrade guide to fit the structure and directly committed, but otherwise, ready to go when the feature PR is released! Thanks for such clear advice! 🎉

@MoustaphaDev MoustaphaDev mentioned this pull request Jan 10, 2025
Merged
ArmandPhilippot
ArmandPhilippot reviewed Jan 10, 2025
View reviewed changes
@MoustaphaDev @ArmandPhilippot
apply Armand's review suggestion
e2d4226 
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jan 13, 2025
@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jan 24, 2025
@MoustaphaDev MoustaphaDev merged commit 7d024fc into main Feb 11, 2025
@MoustaphaDev MoustaphaDev deleted the update-jsx-script-mention branch February 11, 2025 02:03
This was referenced Feb 11, 2025
Merged
Merged
This was referenced Feb 11, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArmandPhilippot ArmandPhilippot ArmandPhilippot left review comments

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees

No one assigned

Labels

add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MoustaphaDev @astrobot-houston @sarah11918 @ArmandPhilippot